Skip to content

Don't hash DelayedLints#155248

Merged
rust-bors[bot] merged 2 commits intorust-lang:mainfrom
JonathanBrouwer:no_hash_delayed_lints
Apr 17, 2026
Merged

Don't hash DelayedLints#155248
rust-bors[bot] merged 2 commits intorust-lang:mainfrom
JonathanBrouwer:no_hash_delayed_lints

Conversation

@JonathanBrouwer
Copy link
Copy Markdown
Contributor

@JonathanBrouwer JonathanBrouwer commented Apr 13, 2026 •
edited
Loading

This PR unblocks #154432, and was also a minor perf win locally

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 13, 2026
@JonathanBrouwer
Copy link
Copy Markdown
Contributor Author

JonathanBrouwer commented Apr 13, 2026

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot pushed a commit that referenced this pull request Apr 13, 2026
@bors
Auto merge of #155248 - JonathanBrouwer:no_hash_delayed_lints, r=<try>
172ee0e 
Don't hash `DelayedLints`
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 13, 2026
@JonathanBrouwer JonathanBrouwer mentioned this pull request Apr 13, 2026
Open
JonathanBrouwer
JonathanBrouwer commented Apr 13, 2026
View reviewed changes
Comment thread compiler/rustc_middle/src/queries.rs
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Apr 13, 2026

☀️ Try build successful (CI)
Build commit: 172ee0e (172ee0e5c78ffeb8f2fc257f0c6f0fa7cf079fef, parent: 14196dbfa3eb7c30195251eac092b1b86c8a2d84)

@rust-timer

This comment has been minimized.

Sign in to view
@JonathanBrouwer JonathanBrouwer marked this pull request as ready for review April 13, 2026 19:43
@JonathanBrouwer
Copy link
Copy Markdown
Contributor Author

JonathanBrouwer commented Apr 13, 2026 •
edited
Loading

r? @GuillaumeGomez
cc @jdonszelmann

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 13, 2026
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Apr 13, 2026
@rustbot

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Copy Markdown
Collaborator

rust-timer commented Apr 13, 2026

Finished benchmarking commit (172ee0e): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.2% [-0.2%, -0.2%] 2
Improvements ✅
(secondary)		 -0.3% [-0.4%, -0.0%] 13
All ❌✅ (primary) -0.2% [-0.2%, -0.2%] 2

Max RSS (memory usage)

Results (primary -2.2%, secondary -1.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 1.5% [0.9%, 2.0%] 2
Improvements ✅
(primary)		 -2.2% [-2.2%, -2.2%] 1
Improvements ✅
(secondary)		 -5.3% [-6.4%, -4.1%] 2
All ❌✅ (primary) -2.2% [-2.2%, -2.2%] 1

Cycles

Results (primary -2.5%, secondary 28.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 28.6% [28.6%, 28.6%] 1
Improvements ✅
(primary)		 -2.5% [-2.9%, -2.1%] 2
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -2.5% [-2.9%, -2.1%] 2

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 491.114s -> 494.706s (0.73%)
Artifact size: 394.23 MiB -> 394.22 MiB (-0.00%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 13, 2026
JonathanBrouwer
JonathanBrouwer commented Apr 13, 2026
View reviewed changes
Comment thread compiler/rustc_hir/src/hir.rs
@JonathanBrouwer JonathanBrouwer added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 13, 2026
@GuillaumeGomez
Copy link
Copy Markdown
Member

GuillaumeGomez commented Apr 13, 2026

Well, sounds good to me and that unblocks #154432 so yeay. r=me once you're sure everything is ok on your side too.

@JonathanBrouwer JonathanBrouwer marked this pull request as draft April 14, 2026 06:47
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Apr 14, 2026
@rustbot rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Apr 17, 2026
@JonathanBrouwer
Copy link
Copy Markdown
Contributor Author

JonathanBrouwer commented Apr 17, 2026

Actually this PR is sound but properly documenting why and making sure it doesn't regress is a challenge

@JonathanBrouwer JonathanBrouwer marked this pull request as ready for review April 17, 2026 14:11
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 17, 2026
@GuillaumeGomez
Copy link
Copy Markdown
Member

GuillaumeGomez commented Apr 17, 2026

Awesome work, thanks!

@bors r+

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Apr 17, 2026

📋 This PR cannot be approved because it currently has the following label: S-blocked.

@JonathanBrouwer JonathanBrouwer removed the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Apr 17, 2026
@JonathanBrouwer
Copy link
Copy Markdown
Contributor Author

JonathanBrouwer commented Apr 17, 2026

@bors r=GuillaumeGomez rollup=never

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Apr 17, 2026

📌 Commit 5c7384e has been approved by GuillaumeGomez

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 17, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors rust-bors bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 17, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Apr 17, 2026

☀️ Test successful - CI
Approved by: GuillaumeGomez
Duration: 3h 10m 58s
Pushing f29256d to main...

@rust-bors rust-bors bot merged commit f29256d into rust-lang:main Apr 17, 2026
12 checks passed
@rustbot rustbot added this to the 1.97.0 milestone Apr 17, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 17, 2026

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 4dbafc3 (parent) -> f29256d (this PR)

Test differences

Show 190 test diffs

Stage 1

  • [incremental] tests/incremental/hashes/delayed_lints.rs: [missing] -> pass (J1)

Stage 2

  • [incremental] tests/incremental/hashes/delayed_lints.rs: [missing] -> pass (J0)
  • [incremental] tests/incremental/hashes/delayed_lints.rs: [missing] -> ignore (gcc backend is marked as ignore) (J2)

Additionally, 187 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard f29256dd1420dc681bf4956e3012ffe9eccdc7e7 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-aarch64-linux: 2h 32m -> 1h 45m (-30.9%)
  2. dist-powerpc64-linux-gnu: 1h 14m -> 1h 31m (+23.2%)
  3. dist-aarch64-apple: 1h 47m -> 2h 8m (+19.5%)
  4. dist-powerpc64le-linux-musl: 1h 17m -> 1h 29m (+16.7%)
  5. dist-x86_64-apple: 1h 52m -> 2h 8m (+14.1%)
  6. x86_64-gnu-debug: 1h 52m -> 2h 4m (+11.2%)
  7. x86_64-gnu-nopt: 2h 15m -> 2h 27m (+9.3%)
  8. x86_64-msvc-ext2: 1h 56m -> 1h 47m (-8.1%)
  9. x86_64-gnu-aux: 2h 21m -> 2h 33m (+8.0%)
  10. x86_64-mingw-2: 2h 43m -> 2h 30m (-8.0%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-bors rust-bors bot mentioned this pull request Apr 17, 2026
Open
@rust-timer
Copy link
Copy Markdown
Collaborator

rust-timer commented Apr 17, 2026

Finished benchmarking commit (f29256d): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.2% [0.2%, 0.2%] 1
Improvements ✅
(primary)		 -0.1% [-0.2%, -0.1%] 3
Improvements ✅
(secondary)		 -0.3% [-0.4%, -0.1%] 20
All ❌✅ (primary) -0.1% [-0.2%, -0.1%] 3

Max RSS (memory usage)

Results (primary 0.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 0.6% [0.6%, 0.6%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.6% [0.6%, 0.6%] 1

Cycles

Results (secondary -6.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -6.2% [-8.5%, -4.0%] 2
All ❌✅ (primary) - - 0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 493.358s -> 490.91s (-0.50%)
Artifact size: 394.12 MiB -> 394.18 MiB (0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

@jdonszelmann jdonszelmann

Labels

merged-by-bors This PR was explicitly merged by bors. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.97.0

Development

Successfully merging this pull request may close these issues.

6 participants

@JonathanBrouwer @rust-timer @rustbot @GuillaumeGomez @mati865 @jdonszelmann