Skip to content

Enable distcheck for aarch64-apple-darwin#156880

Closed
sgasho wants to merge 8 commits into
rust-lang:mainfrom
sgasho:mac-distcheck
Closed

Enable distcheck for aarch64-apple-darwin#156880
sgasho wants to merge 8 commits into
rust-lang:mainfrom
sgasho:mac-distcheck

Conversation

@sgasho

@sgasho sgasho commented May 24, 2026

Copy link
Copy Markdown
Contributor

View all comments

Add a minimal macOS distcheck CI job.

Linux already has an x86_64-gnu-distcheck, which runs x.py test distcheck.
This PR adds the same distcheck for aarch64-apple-darwin.

Background: #gsoc > Project: Bringing autodiff and offload into Rust CI @ 💬

@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels May 24, 2026
@ZuseZ4

ZuseZ4 commented May 24, 2026

Copy link
Copy Markdown
Member

@bors delegate=try

@rust-bors

rust-bors Bot commented May 24, 2026

Copy link
Copy Markdown
Contributor

✌️ @sgasho, you can now perform try builds on this pull request!

You can now post @bors try to start a try build.

@sgasho

sgasho commented May 24, 2026

Copy link
Copy Markdown
Contributor Author

@bors try jobs=aarch64-apple-distcheck

@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request May 24, 2026
Enable distcheck for aarch64-apple-darwin


try-job: aarch64-apple-distcheck
@ZuseZ4 ZuseZ4 requested a review from Kobzol May 24, 2026 14:08
@ZuseZ4

ZuseZ4 commented May 24, 2026

Copy link
Copy Markdown
Member

Ping @Kobzol to make sure it's the check you had in mind, and later approve, if it's fine from an infra perspective. Then we can test the dynamic LLVM PR with this check next.
If you think it's too expensive we can also just keep it while experimenting.

@jieyouxu

jieyouxu commented May 24, 2026

Copy link
Copy Markdown
Member

Do note that aarch64-apple is one of the slowest jobs, I'm curious to see the job time w/ distcheck

@rust-bors

rust-bors Bot commented May 24, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: cdd5b6a (cdd5b6ab68977026e52934a7de39c9169a5dc09d, parent: a06c1ca53a775af31bcbdaeed995c2f224b34d06)

@jieyouxu

Copy link
Copy Markdown
Member

Trying again to get another datapoint
@bors try jobs=aarch64-apple-distcheck

@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request May 24, 2026
Enable distcheck for aarch64-apple-darwin


try-job: aarch64-apple-distcheck
@rust-bors

rust-bors Bot commented May 24, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 0d622e9 (0d622e95b3947713c1b8b8ae5969c9799c33c7d1, parent: 1d59f669f9c699b982f112ebbc81e8b1eb550d68)

@sgasho

sgasho commented May 25, 2026

Copy link
Copy Markdown
Contributor Author

Both runs took 3 hours.

It is slow, but it seems comparable to some of the slower existing auto jobs, dist-aarch64-linux, for example.
Would this be acceptable from the runtime perspective?

I have no idea if this is acceptable from the cost perspective, so I'd keep this as a draft for now

@sgasho

sgasho commented May 26, 2026

Copy link
Copy Markdown
Contributor Author

@bors try jobs=aarch64-apple-distcheck

@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request May 26, 2026
Enable distcheck for aarch64-apple-darwin


try-job: aarch64-apple-distcheck
@ZuseZ4

ZuseZ4 commented May 26, 2026

Copy link
Copy Markdown
Member

This might need a bump https://github.com/rust-lang/rust/pull/153179/changes, but we'll see

@rustbot rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label May 26, 2026
@sgasho

sgasho commented May 26, 2026

Copy link
Copy Markdown
Contributor Author

Thanks, bumped

@bors try jobs=aarch64-apple-distcheck

rust-bors Bot pushed a commit that referenced this pull request May 26, 2026
Enable distcheck for aarch64-apple-darwin


try-job: aarch64-apple-distcheck
@rust-bors

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@ZuseZ4

ZuseZ4 commented May 26, 2026

Copy link
Copy Markdown
Member

spurious
@bors retry

@rust-bors

rust-bors Bot commented May 26, 2026

Copy link
Copy Markdown
Contributor

❗ You can only retry pull requests that are approved and have a previously failed auto build.

@ZuseZ4

ZuseZ4 commented May 26, 2026

Copy link
Copy Markdown
Member

Ah nice, just a normal test failed, the try continues

@rust-bors

rust-bors Bot commented May 26, 2026

Copy link
Copy Markdown
Contributor

💔 Test for e34fcb9 failed: CI. Failed job:

@rust-log-analyzer

This comment has been minimized.

@ZuseZ4

ZuseZ4 commented May 26, 2026

Copy link
Copy Markdown
Member
image

@sgasho

sgasho commented May 26, 2026

Copy link
Copy Markdown
Contributor Author

Ah, this is expected.
This should be fixed in this PR #156971

スクリーンショット 2026-05-27 1 31 52

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-bors

rust-bors Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes made this pull request unmergeable. Please resolve the merge conflicts.

@sgasho sgasho closed this Jun 1, 2026
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants