Rename errors.rs file to diagnostics.rs (2/N)#157535
Conversation
|
Some changes occurred in cc @BoxyUwU Some changes occurred in compiler/rustc_attr_parsing cc @jdonszelmann, @JonathanBrouwer Some changes occurred to diagnostic attributes. cc @mejrs Some changes occurred in check-cfg diagnostics cc @Urgau |
rustbot
added
A-attributes
JonathanBrouwer
changed the title
errors.rs file to diagnostics.rserrors.rs file to diagnostics.rs (2/N)
There was a problem hiding this comment.
rustc_attr_parsing has both errors.rs and session_diagnostics.rs. I think it makes sense to merge those together into a single diagnostics.rs?
There was a problem hiding this comment.
rustc_attr_parsing/attributes/diagnostic/mod.rs also has some diagnostic structs in it, if we're merging files we might as well move those too.
There was a problem hiding this comment.
Time to merge some files then!
There was a problem hiding this comment.
To clarify; I meant "move the diagnostic structs in rustc_attr_parsing/attributes/diagnostic/mod.rs to diagnostics.rs". Not the attribute parsers.
rustbot
added
S-waiting-on-author
|
Moved all diagnostics into |
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
rename-err-to-diag-2
branch
from
139c97a to
feac3e0
Compare
rustbot
added
the
A-meta
| @@ -1,56 +0,0 @@ | |||
| use rustc_feature::AttributeStability; | |||
There was a problem hiding this comment.
Please undo these deletions. same for all the other files in this directory.
5 participants
Follow-up of #157485.
r? @JonathanBrouwer