Strip paramenv v2

[jdonszelmann]

View all comments

[jdonszelmann]

@bors try @rust-timer queue

[jdonszelmann]

@bors try cancel

[rust-bors]

Try build cancelled. Cancelled workflows:

• https://github.com/rust-lang/rust/actions/runs/27705499571

[jdonszelmann]

Oops, left in some debugging infra above, wouldn't be very representative ^^

@bors try @rust-timer queue

[rust-bors]

☀️ Try build successful (CI)
Build commit: cb7a626 (cb7a6269ba868d578a80bd87fff91573c7871c65)
Base parent: 693b3e4 (693b3e4c6e4e686cb9878c1722ad26858b5f1d2a)

[rust-timer]

Finished benchmarking commit (cb7a626): comparison URL.

Overall result: ❌✅ regressions and improvements - please read:

Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf.

Next, please: If you can, justify the regressions found in this try perf run in writing along with @rustbot label: +perf-regression-triaged. If not, fix the regressions and do another perf run. Neutral or positive results will clear the label automatically.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.3%, 0.3%]	1
Regressions ❌ (secondary)	0.3%	[0.2%, 0.3%]	2
Improvements ✅ (primary)	-0.7%	[-0.7%, -0.7%]	1
Improvements ✅ (secondary)	-2.0%	[-4.4%, -0.1%]	26
All ❌✅ (primary)	-0.2%	[-0.7%, 0.3%]	2

Max RSS (memory usage)

Results (primary -4.8%, secondary -2.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.8%	[0.8%, 0.8%]	1
Improvements ✅ (primary)	-4.8%	[-4.8%, -4.8%]	1
Improvements ✅ (secondary)	-2.8%	[-17.0%, -1.1%]	18
All ❌✅ (primary)	-4.8%	[-4.8%, -4.8%]	1

Cycles

Results (secondary -2.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	5.5%	[4.1%, 6.6%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.3%	[-6.9%, -2.5%]	17
All ❌✅ (primary)	-	-	0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 522.375s -> 484.553s (-7.24%)
Artifact size: 401.89 MiB -> 391.12 MiB (-2.68%)

[jdonszelmann]

@bors try @rust-timer queue

[rust-log-analyzer]

The job x86_64-gnu-miri failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[rust-bors]

☀️ Try build successful (CI)
Build commit: 976a309 (976a309544dcb2b72524a059ae887fe4b463e6c4)
Base parent: c55fad5 (c55fad5a9048ad0f7cff2a4867a297647af9392b)

[rust-timer]

Finished benchmarking commit (976a309): comparison URL.

Overall result: ❌✅ regressions and improvements - please read:

Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf.

Next, please: If you can, justify the regressions found in this try perf run in writing along with @rustbot label: +perf-regression-triaged. If not, fix the regressions and do another perf run. Neutral or positive results will clear the label automatically.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.3%	[0.3%, 0.3%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.4%	[-2.5%, -0.3%]	10
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -3.9%, secondary -5.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.9%	[-3.9%, -3.9%]	1
Improvements ✅ (secondary)	-5.5%	[-16.6%, -1.5%]	4
All ❌✅ (primary)	-3.9%	[-3.9%, -3.9%]	1

Cycles

Results (secondary -2.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.6%	[-2.8%, -2.4%]	2
All ❌✅ (primary)	-	-	0

Binary size

Results (primary 0.0%, secondary 0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.0%	[0.0%, 0.0%]	15
Regressions ❌ (secondary)	0.1%	[0.1%, 0.1%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.0%	[0.0%, 0.0%]	15

Bootstrap: 481.592s -> 483.447s (0.39%)
Artifact size: 391.21 MiB -> 391.24 MiB (0.01%)

[rust-bors]

☔ The latest upstream changes (presumably #156742) made this pull request unmergeable. Please resolve the merge conflicts by rebasing.