Rollup of 6 pull requests#158066
Closed
JonathanBrouwer wants to merge 13 commits into
Closed
Conversation
…ameters in by-value returns" This reverts commit 519a555. The regression test added by that commit asserts that redundant stores are present, which locks in suboptimal assembly output and will actively block any future fix from landing.
Clarified how `with_added_extension` deals with the return value from `add_extension`. I added some "interesting" examples to illustrate.
This makes it consistent with the other late internal lints. It doesn't need to be a crate-level pass because it doesn't implement `check_crate` or `check_crate_post` and/or track any crate-level information.
Instead of N separate passes. This is more efficient for bootstrapping. It also matches what is done for builtin lints (`BuiltinCombined*LintPass`).
@abrown has [commented](rust-lang#157644 (comment)) that he is no longer maintaining the target. Update the target maintainers list accordingly.
Put internal lints into a single combined pass Details in individual commits. r? @Urgau
wasm32-wasip1-threads: Correct llvm target name Intends to fix rust-lang#131007, a problem with cross-compiling Rust+C++ to wasm32-wasip1-threads: clang will be told to compile for `--target=wasm32-wasi`, which it interprets as `wasm32-wasip1`, which is not compatible with `wasm32-wasip1-threads`. I wonder if there might be any compatibility issue or something depending on the old incorrect name...
…vooeo Revert "add regression test for Redundant memory strores with mut parameters in by-value returns" This reverts commit 519a555 (PR rust-lang#154841). The regression test added by that commit asserts that redundant stores are present, which locks in suboptimal assembly output and will actively block any future fix from landing. The underlying issue (rust-lang#149762) is therefore not fixed. Since 1.92.0, both `with_rebind` and `with_mut_param` compile to the same suboptimal assembly, whereas in 1.91.0 `with_rebind` at least produced optimal output. A correct regression test should verify that neither function emits redundant stores, and should be added together with an actual fix. rust-lang#149762 (comment)
Document `with_added_extension` edge cases Clarified how `with_added_extension` deals with the return value from `add_extension`. I added some "interesting" examples to illustrate. IMO this function should have returned `Result` but unfortunately the discussion about that was kind of ignored. :-/ We can at least document it well. No AI was used to make this change.
…rs, r=JonathanBrouwer fix unresolved import suggestion before outer attributes Fixes rust-lang#69733. Issue rust-lang#69733 reports an invalid import suggestion where rustc could insert a new `use ...;` item between an outer attribute and the item it annotates. This invalid import suggestion produces broken code. My PR adds a `run-rustfix` UI regression test for that. The fixed output verifies that the suggested import is inserted before the leading outer attribute
rustc book: Update wasm32-wasip1-threads's maintainers list @abrown has [commented](rust-lang#157644 (comment)) that he is no longer maintaining the target. Update the target maintainers list accordingly. r? abrown
rustbot
added
S-waiting-on-review
Contributor
Author
|
@bors r+ rollup=never p=5 |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
Member
|
I deliberately didn't create the n=6 rollup because I knew I'd be reviewing a couple assigned PRs :) I just opened an n=8 rollup instead |
rust-bors
Bot
added
S-waiting-on-author
Contributor
|
This pull request was unapproved due to being closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
with_added_extensionedge cases #158051 (Documentwith_added_extensionedge cases)r? @ghost
Create a similar rollup