Rename Layout to LayoutBitset#1563
Merged
akern40 merged 3 commits intorust-ndarray:masterfrom Jan 4, 2026
Merged
Conversation
In preparation for reworking the inner dimension types (see rust-ndarray#1506), we'd like to prepare the name `Layout` to be used for new traits and types. Although the type is largely internal (with hidden documentation), we opt for a conservative deprecation approach. In the future, we should consider making `LayoutBitset` entirely internal, but this would require larger changes to the codebase.
akern40
added a commit
to akern40/ndarray
that referenced
this pull request
Jan 4, 2026
This is a follow-on to rust-ndarray#1563; it probably should have been the same PR. In additon to reserving the name `Layout`, we'd also like to clean up the `src/layout` module so that we can pack it full of new features for rust-ndarray#1506. So we collapse everything that's currently there into `layout::bitset`, and add a `pub use` declaration to re-export it. As a side note, I'd eventually like `layout` to act as a template for how we handle modules: minimal module-level code and clear module-level documentation. I've made rust-ndarray#1566 to track that library-wide.
akern40
added a commit
that referenced
this pull request
Jan 4, 2026
This is a follow-on to #1563; it probably should have been the same PR. In additon to reserving the name `Layout`, we'd also like to clean up the `src/layout` module so that we can pack it full of new features for #1506. So we collapse everything that's currently there into `layout::bitset`, and add a `pub use` declaration to re-export it. As a side note, I'd eventually like `layout` to act as a template for how we handle modules: minimal module-level code and clear module-level documentation. I've made #1566 to track that library-wide.
akern40
added a commit
to akern40/ndarray
that referenced
this pull request
Jan 7, 2026
This reverts commit d573745. The commit will now live on the `refactor` branch until more of the new layout code is ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation for reworking the inner dimension types (see #1506), we'd like to prepare the name
Layoutto be used for new traits and types. Although the type is largely internal (with hidden documentation), we opt for a conservative deprecation approach.In the future, we should consider making
LayoutBitsetentirely internal, but this would require larger changes to the codebase.