Bump salt-minion-vcf image to v0.1.1 (entrypoint changed since v0.1.0) - #5
Merged
Merged
Conversation
The already-published salt-minion-vcf-image/v0.1.0 was built before the auth_timeout/master_alive_interval/recon_* defaults were added to docker-entrypoint.sh (see PR #4) - that script is baked into the image via COPY, so v0.1.0 doesn't carry the new Docker/env master-config defaults. Tags are immutable per-component releases here, so this cuts v0.1.1 instead of overwriting v0.1.0. Also points the (not-yet-released) salt-minion-vcf chart's default image.tag at 0.1.1, since the chart hasn't shipped yet and should default to the corrected image from its first release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The published `salt-minion-vcf-image/v0.1.0` predates the `auth_timeout`/`master_alive_interval`/`recon_*` entrypoint defaults added in #4. That script is baked into the image at build time, so `v0.1.0` doesn't carry them for the Docker/env config path. Cuts `v0.1.1` instead of overwriting the immutable `v0.1.0` tag, and points the (not-yet-released) chart's default `image.tag` at `0.1.1`.
🤖 Generated with Claude Code