Pr add viruscheck to chocolatey #68558
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sxderp
force-pushed
the
pr-add-viruscheck-to-chocolatey
branch
from
e38072f to
a173652
Compare
Sxderp
force-pushed
the
pr-add-viruscheck-to-chocolatey
branch
from
a173652 to
540d0a1
Compare
Contributor
I believe the opposite is true, salt has and is moving the old tests to pytests. |
Sxderp
force-pushed
the
pr-add-viruscheck-to-chocolatey
branch
from
540d0a1 to
c61c102
Compare
Sxderp
force-pushed
the
pr-add-viruscheck-to-chocolatey
branch
from
c61c102 to
b241db4
Compare
Sxderp
force-pushed
the
pr-add-viruscheck-to-chocolatey
branch
from
b241db4 to
852bb8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the viruscheck argument to the chocolatey cli for installing packages.
https://docs.chocolatey.org/en-us/features/virus-check/#options-and-switches
There are no tests. I'm not sure the best location. I'm thinking they should be added here:
tests/pytests/unit/modules/test_chocolatey.pyThough, I thought I saw somewhere that Salt was trying to move away from pytest stuffs?
What issues does this PR fix or reference?
Fixes
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes/No