fix: replace 3 bare except clauses with except Exception#68772
Closed
haosenwang1018 wants to merge 1 commit intosaltstack:masterfrom
Closed
fix: replace 3 bare except clauses with except Exception#68772haosenwang1018 wants to merge 1 commit intosaltstack:masterfrom
haosenwang1018 wants to merge 1 commit intosaltstack:masterfrom
Conversation
twangboy
requested changes
Feb 26, 2026
Contributor
twangboy
left a comment
twangboy
left a comment
There was a problem hiding this comment.
Let's figure out what the exceptions actually are that we're tyring to catch. except Exception is just as vague as except.
haosenwang1018
force-pushed
the
fix/bare-excepts
branch
from
f834806 to
09d32c8
Compare
Author
|
Closing to reduce review backlog; will revisit with smaller patch if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace bare except clauses with except Exception.