Skip to content

Align 3006.x stress workflow with branch-specific nightly dispatch - #70197

Open
charzl wants to merge 2 commits into
saltstack:3006.xfrom
charzl:feature/run-stress-test
Open

Align 3006.x stress workflow with branch-specific nightly dispatch#70197
charzl wants to merge 2 commits into
saltstack:3006.xfrom
charzl:feature/run-stress-test

Conversation

@charzl

@charzl charzl commented Aug 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary

Align the 3006.x stress execution workflow with the branch-specific nightly dispatcher in #70087. A dispatch with --ref 3006.x selects both the workflow definition and the tested source from 3006.x.

  • Remove the execution workflow's schedule; branch-specific schedulers on the default branch own the timing.
  • Remove the separate branch input and let checkout follow the dispatched ref.
  • Use github.ref_name for the run name, Docker cache keys, artifact name, and snapshot path.
  • Respect the repository-level SKIP_NIGHTLY_STRESS_TEST opt-out.
  • Preserve the existing 3006.x defaults: duration is 0.5h, metrics are disabled, and an empty worker_threads override leaves the branch's master.conf default unchanged. Existing diagnostics and dashboard publishing are preserved.

This changes only .github/workflows/nightly-stress-test.yml on 3006.x. Merge this execution-side update before enabling the independent 3006.x scheduler in #70087.

Validation

  • All applicable local pre-commit checks passed, including workflow generation and actionlint.
  • Standalone actionlint 1.7.12, with shellcheck, passed.
  • The feature commits are rebased onto the latest 3006.x.
  • Parsed YAML checks confirm matching branch refs, no execution-workflow schedule or separate branch input, preservation of the 3006.x input defaults, and a diff containing only the workflow file.
  • bash -n passed for all ten workflow run scripts.
  • Live dispatch/end-to-end stress execution has not been run.

@charzl
charzl requested a review from a team as a code owner August 31, 2026 22:04
@charzl charzl changed the title Enable nightly stress test on 3006.x, matching master's dispatcher/worker split [draft]Enable nightly stress test on 3006.x, matching master's dispatcher/worker split Aug 31, 2026
charzl added a commit that referenced this pull request Aug 31, 2026
@charzl @claude
Revert nightly-stress-test.yml -- port from #70197 lands separately
8c810a9 
This PR's scope shrinks to just run-nightly-stress.yml's matrix
change. nightly-stress-test.yml's rewrite (dispatcher-loop removal,
schedule removal, SKIP_NIGHTLY_STRESS_TEST dedup) is being established
on 3006.x first (#70197) and will be ported to master and 3008.x as
separate, later changes -- not bundled into this PR.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@charzl charzl changed the title [draft]Enable nightly stress test on 3006.x, matching master's dispatcher/worker split Enable nightly stress test on 3006.x, matching master's dispatcher/worker split Aug 31, 2026
@charzl charzl changed the title Enable nightly stress test on 3006.x, matching master's dispatcher/worker split Drop nightly-stress-test.yml's own schedule and branch input on 3006.x Aug 31, 2026
@charzl
charzl force-pushed the feature/run-stress-test branch from e4b1cdc to 9b6a3b3 Compare August 31, 2026 23:30
@charzl charzl added this to the Sulphur v3006.28 milestone Aug 31, 2026
@twangboy

twangboy commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

We are no longer accepting bug fixes on the 3006.x branch. Please rebase against the 3008.x branch.

@charzl
charzl force-pushed the feature/run-stress-test branch from 9b6a3b3 to 288e780 Compare October 15, 2026 17:43
@charzl charzl changed the title Drop nightly-stress-test.yml's own schedule and branch input on 3006.x Align 3008.x stress workflow with branch-specific nightly dispatch Oct 15, 2026
@charzl
charzl changed the base branch from 3006.x to 3008.x October 15, 2026 17:43
@charzl charzl mentioned this pull request Oct 15, 2026
Draft
@charzl charzl added the test:full Run the full test suite label Oct 15, 2026
@charzl charzl changed the title Align 3008.x stress workflow with branch-specific nightly dispatch Align 3006.x stress workflow with branch-specific nightly dispatch Oct 16, 2026
@charzl
charzl changed the base branch from 3008.x to 3006.x October 16, 2026 17:18
@dwoz
dwoz changed the base branch from 3006.x to 3008.x October 22, 2026 00:15
@dwoz

dwoz commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

@charzl 3006.x has entered security only. Please rebase these changes on 3008.x

@charzl charzl changed the title Align 3006.x stress workflow with branch-specific nightly dispatch Align 3008.x stress workflow with branch-specific nightly dispatch Oct 28, 2026
@charzl
charzl force-pushed the feature/run-stress-test branch from d14428c to 67af417 Compare October 28, 2026 19:32
@charzl

charzl commented Oct 28, 2026

Copy link
Copy Markdown
Collaborator Author

@charzl 3006.x has entered security only. Please rebase these changes on 3008.x

Discussed offline， this PR should be rebased on 3006.x

This branch was previously deployed

1 inactive deployment
ci — a95f2648 Deployed Oct 28, 2026 by charzl via Build Onedir Packages / macOS (x86_64) #28001
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@twangboy twangboy twangboy approved these changes

Assignees

@charzl charzl

Labels

test:full Run the full test suite

Projects

None yet

Milestone

Sulphur v3006.31

Development

Successfully merging this pull request may close these issues.

3 participants

@charzl @twangboy @dwoz