Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ dependencies = [
"click>=8.0.0",
"cryptography>=42", # the local transfer CA
"httpx>=0.27.0",
"litellm>=1.96.0,<1.97",
"litellm>=1.96.0,<1.105",
"mcp>=1.25,<2", # same floor as env/gateway/requirements.txt and agentenv-protocol; 2.0.0 removed mcp.server.fastmcp, imported at module scope by env/gateway
"packaging>=22", # evaluates a plugin's requirement markers with no extra
"a2a-sdk==0.3.26",
Expand All @@ -43,9 +43,9 @@ dependencies = [
"python-multipart>=0.0.13", # the local grant server's upload forms
"pyyaml>=6.0",
"starlette>=0.40", # the local grant server
"uvicorn>=0.47", # 0.47 adds ssl_context_factory, how the local grant server gets its TLS context
"uvicorn>=0.29", # 0.47 adds ssl_context_factory, how the local grant server gets its TLS context

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Older installs break local transfers

If a user has uvicorn below 0.47 installed, the lowered >=0.29 requirement now accepts it. The first local transfer grant always calls uvicorn.Config(..., ssl_context_factory=...), but those versions lack that option. This raises TypeError and prevents the grant server from starting.

The newer version in uv.lock does not protect users installing the published package into an existing environment. Restore the >=0.47 minimum.

Suggested change
"uvicorn>=0.29", # 0.47 adds ssl_context_factory, how the local grant server gets its TLS context
"uvicorn>=0.47", # 0.47 adds ssl_context_factory, how the local grant server gets its TLS context
Prompt To Fix With AI
This is a comment left during a code review.
Path: pyproject.toml
Line: 46

Comment:
**Older installs break local transfers**

If a user has `uvicorn` below `0.47` installed, the lowered `>=0.29` requirement now accepts it. The first local transfer grant always calls `uvicorn.Config(..., ssl_context_factory=...)`, but those versions lack that option. This raises `TypeError` and prevents the grant server from starting.

The newer version in `uv.lock` does not protect users installing the published package into an existing environment. Restore the `>=0.47` minimum.

```suggestion
    "uvicorn>=0.47",  # 0.47 adds ssl_context_factory, how the local grant server gets its TLS context
```

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Fix in Cursor Fix in Claude Code Fix in Codex

"modal>=1.5.2.dev22", # dev22 adds _experimental_create(tags=); dev2 added VM-mode V2 (vm_runtime)
"e2b~=2.46.4", # AsyncSandbox/AsyncTemplate APIs validated against the 2.46 line
"e2b>=2.46.4,<2.54.0", # AsyncSandbox/AsyncTemplate APIs validated against the 2.46 line
]

[project.optional-dependencies]
Expand Down Expand Up @@ -74,7 +74,7 @@ sail = [
]
dev = [
"agentenv-framework[aws,explorer,gcp,sail]", # so the AWS, explorer, GCP backend and Sail provider tests run in CI
"griffelib==2.3.0", # the plugin API check; exact, since what it reports as a break changes between releases
"griffelib==2.3.2", # the plugin API check; exact, since what it reports as a break changes between releases
"moto>=5.0.0",
"psycopg2-binary>=2.9.0", # the gateway server module's driver; outside its container only the tests import it
"pytest>=9.0",
Expand Down
Loading
Loading