Skip to content

chore: scrub internal identifiers from tests, fixtures and comments - #51

Merged
polakamtejas merged 2 commits into
mainfrom
tejas/scrub-internal-identifiers
Oct 3, 2026
Merged

polakamtejas merged 2 commits into
mainfrom
tejas/scrub-internal-identifiers

Conversation

@polakamtejas

@polakamtejas polakamtejas commented Oct 2, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Removes identifying internal data from tests, fixtures and comments. Behaviour does not change.

  • Tests and fixtures: internal eval names, run and instance ids, task and delivery layouts, the owning team name and internal image names are now neutral placeholders (multi-env, example-team, example/mcp-server:v1, /app/workspace, …). The golden wire-format fixtures and the tests that pin them change together.
  • Comments and docstrings: removed or reworded where they named internal repos, pipelines or types, cited internal PR and review numbers, or quoted production measurements. Where a comment explained something, the rationale stays and only the internal detail goes.

Deliberately not touched:

Test plan

  • pytest tst/unit packages/agentenv-protocol/tests: 5783 passed, 13 skipped. The 2 failures in test_mcp_cli_builder.py are environmental and also happen on main: the generated CLI's interpreter has no click.
  • Golden wire-format tests pass with the updated fixtures.
  • check_plugin_api.py: no break to the plugin surface.
  • Explorer UI: tsc --noEmit, npm run test:smoke, npm run build:static.

🤖 Generated with Claude Code

RetriggerConfidence Score: 5/5

The PR appears safe to merge; no new actionable issue or outstanding previous finding was established.

What we checked:

  • Short file uploads: The reader checks the total bytes written against the file size and raises instead of returning the partial file.

Summary

This PR replaces identifying examples in tests and golden fixtures with neutral placeholders, and removes internal references from comments. The test scenarios and runtime behavior stay the same.

  • Test inputs now use generic team names, environment IDs, image names, and artifact paths.
  • Golden JSON fixtures change alongside the test data that produces them.
  • Comments keep their technical explanations without internal project names, run IDs, issue numbers, or production details.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Tag[Version tag] --> Protocol[Publish protocol]
  Protocol --> Framework[Publish framework]
  Framework --> Release[Create GitHub release]
  CUA[CUA file] --> Size[Check file size]
  Size --> Small[Fetch small file]
  Size --> Large[Read large file in chunks]
  Small --> Upload[Upload artifact]
  Large --> Upload
Loading

Reviews (2) · Last reviewed commit: "Merge branch 'main' into tejas/scrub-int..."

Replace internal eval names, run and instance ids, task layouts, team and
image names in tests and fixtures with neutral placeholders, and drop
comments that only carried internal context: references to internal repos
and pipelines, internal PR and review numbers, and production measurements.
No behaviour change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@polakamtejas
polakamtejas requested a review from a team as a code owner October 2, 2026 17:05
@polakamtejas
polakamtejas enabled auto-merge (squash) October 3, 2026 14:06
@polakamtejas
polakamtejas merged commit 10deb07 into main Oct 3, 2026
13 checks passed
@polakamtejas
polakamtejas deleted the tejas/scrub-internal-identifiers branch October 3, 2026 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants