Skip to content

Speed up unit tests#595

Open
Femimat wants to merge 3 commits intoscribe-org:mainfrom
Femimat:issue-580-speed-up-tests
Open

Speed up unit tests#595
Femimat wants to merge 3 commits intoscribe-org:mainfrom
Femimat:issue-580-speed-up-tests

Conversation

@Femimat
Copy link
Copy Markdown
Contributor

@Femimat Femimat commented Mar 31, 2026

Contributor checklist


Description

  1. Matrix Strategy: I added a matrix strategy to parallelize the tests for the Conjugate and Keyboards flavors. This allows both sets of tests to run at the same time on different runners.
  2. Pre-building APKs: I added a Pre-build Android Test APKs step that runs before the emulator starts. This prevents the build process from competing for resources with the emulator, which can lead to timeouts and slower test execution.
  3. Removed redundant delays: I removed the sleep 30 and sleep 10 commands, as android-emulator-runner handles waiting for the device. I also removed redundant animation settings that are already handled by the disable-animations: true flag.
  4. Workflow Cleanup:

@github-actions
Copy link
Copy Markdown

Thank you for the pull request! 💙🩵

The Scribe-Android team will do our best to address your contribution as soon as we can. The following are some important points:

  • Those interested in developing their skills and expanding their role in the community should read the mentorship and growth section of the contribution guide
  • If you're not already a member of our public Matrix community, please consider joining!
    • We'd suggest that you use the Element client as well as Element X for a mobile app
    • Join the General and Android rooms once you're in
  • Also consider attending our bi-weekly Saturday developer syncs!
    • Details are shared in the General room on Matrix each Wednesday before the sync
    • It would be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions
Copy link
Copy Markdown

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • Tests for changes have been written and the unit test, linting and formatting workflows within the PR checks do not indicate new errors in the files changed

    • Tests may need to be reran as they're at times not deterministic
  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@Femimat Femimat changed the title Speed up unit tests and resolve CI conflicts Speed up unit tests Mar 31, 2026
@andrewtavis
Copy link
Copy Markdown
Member

Can you take a look at the merge conflicts, @Femimat? Let us know when this is ready for a review :)

@Femimat
Copy link
Copy Markdown
Contributor Author

Femimat commented Mar 31, 2026

Hi @andrewtavis, thanks for the heads up! I’m currently working on resolving the merge conflicts and will let you know once it’s ready for review.

@Femimat
Copy link
Copy Markdown
Contributor Author

Femimat commented Apr 1, 2026

Hi @andrewtavis, you can review the PR now.

@andrewtavis
Copy link
Copy Markdown
Member

Sounds good, @Femimat! Thanks for resolving the conflicts 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants