Conversation
Thank you for the pull request! 💙🩵The Scribe-Android team will do our best to address your contribution as soon as we can. The following are some important points:
Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
|
|
Can you take a look at the merge conflicts, @Femimat? Let us know when this is ready for a review :) |
|
Hi @andrewtavis, thanks for the heads up! I’m currently working on resolving the merge conflicts and will let you know once it’s ready for review. |
|
Hi @andrewtavis, you can review the PR now. |
|
Sounds good, @Femimat! Thanks for resolving the conflicts 😊 |
Contributor checklist
./gradlew lintKotlin detekt testcommand as directed in the testing section of the contributing guideDescription
Renamed the "Run Ktlint" step in the test job to "Run Unit Tests" to accurately reflect that it runs ./gradlew test.
Adjusted timeout-minutes to a more appropriate 45 minutes per parallel job.
Investigate and speed up Android instrumentation tests #580