fix: finalize UI of no language data keyboard state (#633)#635
Open
prince-0408 wants to merge 1 commit intoscribe-org:mainfrom
Open
fix: finalize UI of no language data keyboard state (#633)#635prince-0408 wants to merge 1 commit intoscribe-org:mainfrom
prince-0408 wants to merge 1 commit intoscribe-org:mainfrom
Conversation
- Hide the Scribe key and its shadow when the download data button is shown - Light mode: solid orange background (scribeCTA) with black text for accessibility - Dark mode: dark warm-brown background with orange border, orange text and icon (outlined style) - Use non-filled arrow.down.circle icon instead of arrow.down.circle.fill - Button spans full keyboard width, aligned to command bar position - Scribe key is restored when language data is available or during command states - Dark mode colors update automatically via traitCollectionDidChange -> loadKeys()
Thank you for the pull request! 💙🩵The Scribe-iOS team will do our best to address your contribution as soon as we can. The following are some important points:
Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finalizes the UI for the keyboard state shown when no language data has been downloaded, addressing all design requirements outlined in the issue.
Closes #633
Changes
scribeCTAColorwith white textscribeCTAColor(orange) with black textarrow.down.circle.fill(filled)arrow.down.circle(non-filled)traitCollectionDidChangeImplementation Details
KeyboardViewController.swiftshowDownloadDataBtn()KeyboardViewController.swiftconditionallyShowDownloadDataBtn()scribeKey.isHidden = falsewhen button is hiddenDesign Spec Checklist
arrow.down.circle)Notes
#2E1F0D) with an orange border and orange text/icon — matching the outlined style shown in the design specKeyboardViewController.swifttraitCollectionDidChange→loadKeys()→conditionallyShowDownloadDataBtn()flow, so no additional observer setup was neededScreenshot