feat(download): add offline network indicator #636
Open
prince-0408 wants to merge 1 commit intoscribe-org:mainfrom
Open
feat(download): add offline network indicator #636prince-0408 wants to merge 1 commit intoscribe-org:mainfrom
prince-0408 wants to merge 1 commit intoscribe-org:mainfrom
Conversation
- Add NetworkMonitor singleton (NWPathMonitor) that passively tracks network reachability on a background utility queue - Guard handleDownloadAction in DownloadStateManager to block downloads when offline and show a toast: 'No internet connection. Please connect and try again.' - Guard checkAllForUpdates to block the 'check for new data' spinner when offline with the same toast feedback - No existing logic removed — guards are purely additive early-returns - Reuses the existing ToastView/ToastModifier infrastructure Closes: offline silent failure on download screen
Thank you for the pull request! 💙🩵The Scribe-iOS team will do our best to address your contribution as soon as we can. The following are some important points:
Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #637
Summary
Prevents silent failures on the download screen by detecting offline state before any network action is attempted, and surfacing a clear toast to the user.
Problem & Solution
NWPathMonitorsingleton, passive background trackingChanges
NetworkMonitor.swiftNWPathMonitorsingletonDownloadStateManager.swifthandleDownloadAction&checkAllForUpdatesNotes
ToastView/ToastModifierinfrastructureNWPathMonitoris Apple-native — no new dependenciesScreenshot
Toast shown when tapping "Update all", "Download data", or "Check for new data" while offline.