feat: add keyboard theme picker with 37 themes across 6 sections#644
Open
prince-0408 wants to merge 2 commits intoscribe-org:mainfrom
Open
feat: add keyboard theme picker with 37 themes across 6 sections#644prince-0408 wants to merge 2 commits intoscribe-org:mainfrom
prince-0408 wants to merge 2 commits intoscribe-org:mainfrom
Conversation
- Add KeyboardTheme struct with ThemeCategory enum (Classic, Dark, Light, Gradient, Neon, Nature, Cultural, Accessible) - Add ThemeManager to persist and apply themes via shared UserDefaults - Add 37 built-in themes including gradient, neon, cultural (Berlin, Paris, Madrid, Stockholm) and accessible (HC Dark, HC Light, Warm AA) themes - Add ThemePickerViewController with Gboard-style sectioned 3-column grid, CAGradientLayer previews for gradient themes, and system-adaptive colors - Wire theme picker into Settings tab with live theme name subtitle - Hook ThemeManager.loadSavedTheme() into keyboard load and trait change - Add keyboardTheme case to UserInteractiveState and SectionState handling
Thank you for the pull request! 💙🩵The Scribe-iOS team will do our best to address your contribution as soon as we can. The following are some important points:
Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) |
- Add messages to all fatalError calls (fatal_error_message rule) - Refactor drawKey to use CGRect parameter instead of x/y/w/h to reduce parameter count below the 5-param limit (function_parameter_count rule)
prince-0408
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a complete keyboard theme customization system to Scribe-iOS, allowing users to personalize the appearance of all installed language keyboards from the Settings tab.
Closes #643
Changes
New Files
Keyboards/KeyboardsBase/KeyboardTheme.swiftKeyboardThemestruct,ThemeCategoryenum, 37 built-in themes, andThemeManagerfor persistence and applicationScribe/Themes/ThemePickerViewController.swiftModified Files
KeyboardViewController.swiftThemeManager.shared.loadSavedTheme()on load and on trait changeSettingsTableData.swiftSettingsViewController.swiftThemePickerViewControlleron theme row tapInfoChildTableViewCell.swiftParentTableCellModel.swift.keyboardThemetoUserInteractiveStateTheme Categories
How It Works
ThemePickerViewControllerpresents a sectioned grid of theme cardsThemeManager.shared.apply(theme), which mutates the global color vars and saves the theme ID to the sharedUserDefaultsapp groupThemeManager.shared.loadSavedTheme()to read the saved ID and re-apply colors before renderingTesting
ScreenShot