perf: cache apply_parameters to avoid repeated type() class creation (~5us saving - 30x speedup per call)#794
Draft
mykaul wants to merge 1 commit intoscylladb:masterfrom
Draft
Conversation
Cache the results of _CassandraType.apply_parameters() in a class-level dict keyed by (cls, subtypes, names). This avoids the expensive type() metaclass machinery on repeated calls with the same type signature, which is the common case during result-set deserialization. Benchmark: 31.7x speedup (6.48 us/call -> 0.20 us/call) for cached hits.
mykaul
force-pushed
the
perf/cache-apply-parameters
branch
from
90c77b5 to
5d25b9b
Compare
mykaul
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_CassandraType.apply_parameters()in a class-level dict keyed by(cls, subtypes, names)type()metaclass machinery on repeated calls with the same type signature (common case during result-set deserialization)cassandra/cqltypes.pyBenchmark
Measured with
min()oftimeit.repeat(repeat=7, number=200_000)on a quiet machine (load <1).Savings: 5339 ns/call
Tests