Skip to content

Fix flaky unit test #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pvk-developer merged 2 commits into from
Feb 18, 2026
Merged

Fix flaky unit test #525

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b32621
Reduce the tolerance to 4 digits instead
pvk-developer Feb 18, 2026
9e0272e
Update other flaky tests
pvk-developer Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 18 additions & 18 deletions tests/unit/multivariate/test_gaussian.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ def test__transform_to_normal_numpy_1d(self):
])
returned = gm._transform_to_normal(data)

# Check
# Assert
# Failures may occurr on different cpytonn implementations
# with different float precision values.
# If that happens, atol might need to be increased
Expand Down Expand Up @@ -147,7 +147,7 @@ def test__transform_to_normal_numpy_2d(self):
])
returned = gm._transform_to_normal(data)

# Check
# Assert
# Failures may occurr on different cpytonn implementations
# with different float precision values.
# If that happens, atol might need to be increased
Expand Down Expand Up @@ -178,7 +178,7 @@ def test__transform_to_normal_series(self):
data = pd.Series({'a': 3, 'b': 5})
returned = gm._transform_to_normal(data)

# Check
# Assert
# Failures may occurr on different cpytonn implementations
# with different float precision values.
# If that happens, atol might need to be increased
Expand Down Expand Up @@ -211,7 +211,7 @@ def test__transform_to_normal_dataframe(self):
data = pd.DataFrame({'a': [3, 4, 5], 'b': [5, 6, 7]})
returned = gm._transform_to_normal(data)

# Check
# Assert
# Failures may occurr on different cpytonn implementations
# with different float precision values.
# If that happens, atol might need to be increased
Expand Down Expand Up @@ -243,7 +243,7 @@ def test__get_correlation(self):
# Run
correlation = copula._get_correlation(self.data)

# Check
# Assert
assert np.isclose(correlation, expected_correlation).all().all()

def test_fit_default_distribution(self):
Expand All @@ -270,7 +270,7 @@ def test_fit_distribution_arg(self):
# Run
copula.fit(self.data)

# Check
# Assert
assert copula.distribution == 'copulas.univariate.gaussian_kde.GaussianKDE'

for i, key in enumerate(self.data.columns):
Expand Down Expand Up @@ -314,7 +314,7 @@ def test_fit_numpy_array(self):
# Run
copula.fit(self.data.to_numpy())

# Check
# Assert
for key, (column, univariate) in enumerate(zip(self.data.columns, copula.univariates)):
assert univariate._params['loc'] == np.mean(self.data[column])
assert univariate._params['scale'] == np.std(self.data[column])
Expand All @@ -336,7 +336,7 @@ def test_fit_broken_distribution(self, logger_mock, truncated_mock):
data = self.data['column1']
copula.fit(data)

# Check
# Assert
expected_logging_msg = (
'Unable to fit to a copulas.univariate.truncated_gaussian.TruncatedGaussian '
'distribution for column column1. Using a Gaussian distribution instead.'
Expand Down Expand Up @@ -466,7 +466,7 @@ def test_probability_density(self):
# Run
result = copula.probability_density(X)

# Check
# Assert
assert expected_result - 1e-16 < result < expected_result + 1e-16

def test_cumulative_distribution_fit_df_call_np_array(self):
Expand All @@ -480,8 +480,8 @@ def test_cumulative_distribution_fit_df_call_np_array(self):
# Run
result = copula.cumulative_distribution(X)

# Check
assert np.isclose(result, expected_result, atol=1e-5).all().all()
# Assert
assert np.isclose(result, expected_result, atol=1e-4).all().all()

def test_cumulative_distribution_fit_call_np_array(self):
"""Cumulative_density integrates the probability density along the given values."""
Expand All @@ -494,8 +494,8 @@ def test_cumulative_distribution_fit_call_np_array(self):
# Run
result = copula.cumulative_distribution(X)

# Check
assert np.isclose(result, expected_result, atol=1e-5).all().all()
# Assert
assert np.isclose(result, expected_result, atol=1e-4).all().all()

def test_cumulative_distribution_fit_call_pd(self):
"""Cumulative_density integrates the probability density along the given values."""
Expand All @@ -508,8 +508,8 @@ def test_cumulative_distribution_fit_call_pd(self):
# Run
result = copula.cumulative_distribution(X)

# Check
assert np.isclose(result, expected_result, atol=1e-5).all().all()
# Assert
assert np.isclose(result, expected_result, atol=1e-4).all().all()

@patch('copulas.multivariate.gaussian.np.random.multivariate_normal')
def test_sample(self, normal_mock):
Expand Down Expand Up @@ -544,7 +544,7 @@ def test_sample(self, normal_mock):
# Run
result = instance.sample(5)

# Check
# Assert
assert result.equals(expected_result)

np.testing.assert_array_equal(
Expand Down Expand Up @@ -580,7 +580,7 @@ def test_sample_random_state(self):
# Run
result = instance.sample(5)

# Check
# Assert
pd.testing.assert_frame_equal(result, expected_result)

def test_to_dict(self):
Expand Down Expand Up @@ -634,7 +634,7 @@ def test_sample_constant_column(self):
# Run
result = instance.sample(5)

# Check
# Assert
assert result.shape == (5, 2)
results = result[~result.isna()].all()
assert results.all()
Expand Down