Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR primarily fixes the EdgeFunction's SemiRing. According to the definition of semi-rings, the neutral element of the combine-operation (here
AllTop) must be an annihilator of the extend-operation on both sides, left and right.As
AllTopis a constant edge-function, the right-annihilation is satisfied; however, left-annihilation is not.As a consequence of this bug, one cannot just return an
AllTopedge-function to kill a data-flow fact. The fact still holds and has a non-top edge-function attached.ThisPR fixes that issue + some minor things.