Enable reference_types parsing for Rust 1.82+ compatibility#3
Open
masih wants to merge 1 commit intorelease/v1.5.xfrom
Open
Enable reference_types parsing for Rust 1.82+ compatibility#3masih wants to merge 1 commit intorelease/v1.5.xfrom
masih wants to merge 1 commit intorelease/v1.5.xfrom
Conversation
Rust 1.82+ emits call_indirect with a multi-byte LEB128 table index (e.g., 0x80 0x00) instead of the single-byte 0x00 required by MVP. Both encode table index 0, but wasmparser ≥0.95 rejects multi-byte encodings when reference_types is disabled. This caused state sync failures with the error: "reference-types not enabled: zero byte expected (at offset 0xNNN)" The fix enables reference_types at the parsing layer only. Security is maintained because the Gatekeeper middleware still blocks all dangerous reference-types instructions (table.grow, ref.null, etc.) regardless of this parsing flag. Fixes state sync on arctic-1 after v6.3 upgrade.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rust 1.82+ emits call_indirect with a multi-byte LEB128 table index (e.g., 0x80 0x00) instead of the single-byte 0x00 required by MVP. Both encode table index 0, but wasmparser ≥0.95 rejects multi-byte encodings when reference_types is disabled.
This caused state sync failures with the error:
"reference-types not enabled: zero byte expected (at offset 0xNNN)"
The fix enables reference_types at the parsing layer only. Security is maintained because the Gatekeeper middleware still blocks all dangerous reference-types instructions (table.grow, ref.null, etc.) regardless of this parsing flag.
Fixes state sync on arctic-1 after v6.3 upgrade.