Open
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2787 +/- ##
==========================================
- Coverage 56.58% 46.91% -9.67%
==========================================
Files 2033 1967 -66
Lines 166263 160953 -5310
==========================================
- Hits 94074 75519 -18555
- Misses 63926 78869 +14943
+ Partials 8263 6565 -1698
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
75fa180 to
bf4ea52
Compare
stevenlanders
approved these changes
Jan 30, 2026
arajasek
approved these changes
Jan 30, 2026
cd111c4 to
e7378f8
Compare
e7378f8 to
ba85a41
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
We used to take a Snapshot of the store whenever an EVM transaction starts, even if it's just a value transfer, because we need the original context to serve
GetCommittedState. Taking snapshot is expensive from an allocation standpoint. This PR adds a new method oncachekv.Storeso that for giga,GetCommittedStatecan invoke the new method instead of having to take a snapshot at the beginning.Testing performed to validate your change
unit tests