Skip to content

fix: suppress expected ErrAggregateVoteExist error logs in gasless metrics#2796

Open
blindchaser wants to merge 3 commits intomainfrom
yiren/fix-log
Open

fix: suppress expected ErrAggregateVoteExist error logs in gasless metrics#2796
blindchaser wants to merge 3 commits intomainfrom
yiren/fix-log

Conversation

@blindchaser
Copy link
Contributor

@blindchaser blindchaser commented Feb 4, 2026

Describe your changes and provide context

When gasless metrics are evaluated after tx processing, oracle vote txs return ErrAggregateVoteExist because the vote now exists in state. This change treats ErrAggregateVoteExist as a signal that the tx was a gasless oracle vote and skips gas metrics recording, while still logging other unexpected errors.

Testing performed to validate your change

@github-actions
Copy link

github-actions bot commented Feb 4, 2026

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedFeb 5, 2026, 3:23 PM

@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

❌ Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.60%. Comparing base (bcfab9b) to head (f72b62b).

Files with missing lines Patch % Lines
app/app.go 12.50% 5 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2796      +/-   ##
==========================================
- Coverage   56.62%   56.60%   -0.03%     
==========================================
  Files        2031     2031              
  Lines      165929   165935       +6     
==========================================
- Hits        93962    93927      -35     
- Misses      63734    63774      +40     
- Partials     8233     8234       +1     
Flag Coverage Δ
sei-chain 41.45% <12.50%> (-0.01%) ⬇️
sei-cosmos 48.12% <ø> (+<0.01%) ⬆️
sei-db 68.72% <ø> (ø)
sei-tendermint 58.07% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
app/app.go 65.85% <12.50%> (-0.22%) ⬇️

... and 23 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blindchaser blindchaser requested a review from yzang2019 February 5, 2026 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants