fix: suppress expected ErrAggregateVoteExist error logs in gasless metrics#2796
Open
blindchaser wants to merge 3 commits intomainfrom
Open
fix: suppress expected ErrAggregateVoteExist error logs in gasless metrics#2796blindchaser wants to merge 3 commits intomainfrom
blindchaser wants to merge 3 commits intomainfrom
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2796 +/- ##
==========================================
- Coverage 56.62% 56.60% -0.03%
==========================================
Files 2031 2031
Lines 165929 165935 +6
==========================================
- Hits 93962 93927 -35
- Misses 63734 63774 +40
- Partials 8233 8234 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
477d398 to
0b5ccce
Compare
0b5ccce to
616a2e1
Compare
codchen
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
When gasless metrics are evaluated after tx processing, oracle vote txs return ErrAggregateVoteExist because the vote now exists in state. This change treats ErrAggregateVoteExist as a signal that the tx was a gasless oracle vote and skips gas metrics recording, while still logging other unexpected errors.
Testing performed to validate your change