Update ledger-go dependency#2798
Open
patrickjeremic wants to merge 1 commit intosei-protocol:mainfrom
Open
Conversation
7581fc6 to
48860ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Currently sei-chain uses a old version of ledger-go (v0.14.1) which does not recognize the newer range of ledger devices.
This PR simply does:
Testing performed to validate your change
On the current main branch of sei-chain it's not possible to add more modern ledger devices (in my testing i used a Ledger Nano S Plus on Firmware 1.5.1 running Cosmos App v2.38.9).
Here's what happens when trying to add the key via
sei-chain:This makes sense, as only v1.0.0 and newer add the HID ids for the newer ledger devices.
After applying the patch it works:
I think the responsible ledger-go change is: Zondax/ledger-go@33eff3c