feat: add configurable io rate limiting for snapshot writes#2802
Open
blindchaser wants to merge 1 commit intorelease/v6.3from
Open
feat: add configurable io rate limiting for snapshot writes#2802blindchaser wants to merge 1 commit intorelease/v6.3from
blindchaser wants to merge 1 commit intorelease/v6.3from
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release/v6.3 #2802 +/- ##
================================================
+ Coverage 45.17% 45.95% +0.78%
================================================
Files 853 1199 +346
Lines 70076 104465 +34389
================================================
+ Hits 31654 48011 +16357
- Misses 35760 52224 +16464
- Partials 2662 4230 +1568
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
yzang2019
approved these changes
Feb 4, 2026
cursor bot
pushed a commit
that referenced
this pull request
Feb 5, 2026
- Analyzed snapshot write rate limiting implementation - Validated design decisions and code quality - Identified pre-existing test failure in storev2/rootmulti (unrelated) - Recommendation: APPROVE with minor notes - All tests passing, well-designed global rate limiter approach Co-authored-by: Steven Landers <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Background
v6.3 optimized snapshot creation time from >3 hours to ~20 minutes using aggressive parallel writes. While this improves performance on high-end machines, it can cause high I/O bursts that may impact page cache efficiency on systems with limited RAM.
Solution
Add optional I/O rate limiting for snapshot writes:
sc-snapshot-write-rate-mbps(default: 0 = unlimited)Configuration Example
[state-commit]
sc-snapshot-write-rate-mbps = 300