Open
Conversation
…ss in PNGroupNode
…ession into a simple name
…roup-13.0.0-2025-07-30
…roup-14.0.0-2026-02-23
|
|
1 similar comment
|
|
…roup-14.0.0-2026-02-23
…roup-14.0.0-2026-02-23
Contributor
Author
|
I added a small change and pushed it today in this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifications made to improve Band Grouping. Note a related (likely dependent) pull request appears in both snap-engine and snap-desktop. So all description is given here in this pull request.
Some example matches:
Note in this scenario there is a boolean field:
snap-core/src/main/java/eu/esa/snap/core/datamodel/group/BandGroupingPath.java line 16:
boolean useStartsWithInsteadOfContains = false;
SeaDAS sets this to "true" which changes the behavior to:
"Rrs" would match any bandnames starting with "Rrs"
For example "^Rrs*" would ignore "^" as a match criteria.
The display folder removes "" if at start or end of name, but not in the middle of the name:
For example:
"Rrs" creates folder "Rrs"
"Rrs" creates folder "Rrs"
but "Rrsunc" create folder "Rrs*unc"
6 "Coords#latitude,longitude" would match bandnames "latitude" and "longitude" and create a display folder named "Coords".