Add fail2ban-friendly auth failure logging and regression test#91
Open
rezdm wants to merge 1 commit intoserjs:masterfrom
Open
Add fail2ban-friendly auth failure logging and regression test#91rezdm wants to merge 1 commit intoserjs:masterfrom
rezdm wants to merge 1 commit intoserjs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #90
Summary
This PR improves authentication failure observability and fail2ban integration by adding a stable, parseable auth failure log line with source IP details.
What Changed
go-socks5auth flow (method,username,reason,remote_ip,remote_addr).ServeConnfor auth failures:auth_failed remote_ip=... remote_addr=... username=... method=... reason=...TestAuthFailureLogsIncludeFail2banFieldsthat performs a real SOCKS5 username/password handshake with invalid credentials and validates:0x01 0x01)auth_failed,remote_ip,username,method, andreason=invalid_credentialsin logsChangelog.mdunderUnreleased.Example Log
[WARN] socks: auth_failed remote_ip=127.0.0.1 remote_addr="127.0.0.1:47966" username="testuser" method=2 reason=invalid_credentialsValidation
GOCACHE=/tmp/go-build-cache go test ./...GOCACHE=/tmp/go-build-cache go vet ./...