fix: Deploy bucket in configured location#227
Merged
medikoo merged 2 commits intoserverless:masterfrom Jul 7, 2020
Merged
Conversation
medikoo
suggested changes
Jul 7, 2020
package/lib/prepareDeployment.js
Outdated
| const newBucket = _.cloneDeep(bucket); | ||
| newBucket.name = name; | ||
| if (location) { | ||
| newBucket.properties = newBucket.properties || {}; |
Contributor
There was a problem hiding this comment.
Let's write it as if (!newBucket.properties) newBucket.properties = {}
Contributor
Author
There was a problem hiding this comment.
Improvement done.
Of course, I tested it ;)
medikoo
approved these changes
Jul 7, 2020
|
When will the next release be available with this fix? |
Contributor
|
@curtismenmuir just published v3.1.1 |
|
@medikoo Perfect, thank you :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a basic correction for the issue #226
Tell me if I can do something better !
Note that this PR is similar to #220