Conversation
|
It seems that the changes are not complete. I still find some deps need changes or |
|
I tested it with |
I built with |
|
Merged your branch as your PR for the dependency was merged and released. |
|
More changes are needed in the |
emilio
left a comment
emilio
left a comment
There was a problem hiding this comment.
looks ok, but can you rebase and add the license headers? Thanks
olanod
force-pushed
the
no-std-support
branch
from
b96cd47 to
0d98d46
Compare
| serde = { version = "1.0", features = ["derive"], optional = true } | ||
| cssparser = { path = "..", default-features = false } | ||
| serde = { version = "1.0", default-features = false, features = ["derive"], optional = true } | ||
| libm = "0.2.8" |
There was a problem hiding this comment.
Ah, I missed this. It seems this dependency should be optional, and only enabled if std is disabled?
| [dependencies] | ||
| cssparser-macros = { path = "./macros", version = "0.6.1" } | ||
| dtoa-short = "0.3" | ||
| dtoa-short = "0.3.5" |
| pub(crate) fn f32_trunc(val: f32) -> f32 { | ||
| #[cfg(feature = "std")] | ||
| { val.round() } | ||
| #[cfg(not(feature = "std"))] | ||
| { libm::roundf(val) } | ||
| } |
There was a problem hiding this comment.
This seems to be a typo. Should call into trunc function not round functions
4 participants
Make crate no_std while keeping it backwards compatible with a default
stdfeature enabled(only used to impl Error for ParseError).