tests: load JSON fixtures at runtime for crates.io archives - #444
Open
rome-xi wants to merge 3 commits into
Open
tests: load JSON fixtures at runtime for crates.io archives#444rome-xi wants to merge 3 commits into
rome-xi wants to merge 3 commits into
Conversation
Signed-off-by: rome-xi <rome-xi@users.noreply.github.com>
emilio
approved these changes
Aug 24, 2026
Member
|
Please run cargo fmt so CI is happy, looks good with that :) |
emilio
requested changes
Aug 24, 2026
emilio
left a comment
emilio
left a comment
Member
There was a problem hiding this comment.
(Ticking request changes so I notice when it gets updated)
Co-authored-by: rome-xi <rome-xi@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #213.
Replace
include_str!for the CSS parsing JSON fixtures withstd::fs::read_to_stringsocargo testcompiles from the crates.io package (those files are inexclude). Missing fixtures still fail at runtime (no silent green); they can be--skipped when packaging.