Remove jackson related for linkpreview#1931
Merged
SessionHero01 merged 2 commits intodevfrom Feb 13, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request migrates link preview serialization from Jackson to kotlinx.serialization, aligning with the codebase's preferred serialization approach. It also converts the AttachmentId class from Java to Kotlin.
Changes:
- Replaced Jackson annotations with kotlinx.serialization in LinkPreview class
- Converted AttachmentId from Java to Kotlin data class with @serializable annotation
- Updated MmsDatabase to use kotlinx.serialization for encoding/decoding link previews
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| LinkPreview.kt | Converted from class to data class with @serializable annotation, removed Jackson dependencies, and made thumbnail property immutable |
| AttachmentId.kt | New Kotlin data class replacing Java implementation, added @serializable and @parcelize annotations |
| AttachmentId.java | Removed Java implementation in favor of Kotlin |
| MmsDatabase.kt | Updated to use json.decodeFromString/encodeToString instead of Jackson, removed unused imports, improved error message accuracy |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...src/main/java/org/session/libsession/messaging/sending_receiving/attachments/AttachmentId.kt
Outdated
Show resolved
Hide resolved
ThomasSession
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.