Skip to content

Implement namespaces and simple binary support.#22

Open
as-roman-o wants to merge 1 commit intoshokai:masterfrom
as-roman-o:namespaces_and_binary
Open

Implement namespaces and simple binary support.#22
as-roman-o wants to merge 1 commit intoshokai:masterfrom
as-roman-o:namespaces_and_binary

Conversation

@as-roman-o
Copy link

@as-roman-o as-roman-o commented Oct 23, 2018

Implement namespaces https://socket.io/docs/rooms-and-namespaces/

client = SocketIO::Client::Simple.connect url, path: '/custom_namespace'

and simple binary support. If you want to send binary data, you should put this packet (byte array) to SocketIO::Client::Simple::ByteBuffer class via SocketIO::Client::Simple.as_byte_buffer method:

client.emit :binary, SocketIO::Client::Simple.as_byte_buffer(byte_array)

@shokai Could you please provide review?

@RomanKisilenko
Copy link

@shokai Hi, not sure if you have time to take care to review this PR and make a release. We are developing a product which relies on your gem but requires support for extra features added in this PR. We appreciate if you can merge and release this PR soon.
Let me know if you think it is better for us to fork your gem instead.

@RomanKisilenko
Copy link

We have published the updated version here for now: https://rubygems.org/gems/statscloud.io-ruby-socket.io-client-simple

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants