-
Notifications
You must be signed in to change notification settings - Fork 102
add additional env variables to fulcio chart #790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
dbd368c to
674cab3
Compare
|
On this though would it make sense to use a pattern more similar to Rekor for extra env vars? https://github.com/sigstore/helm-charts/blob/main/charts/rekor/templates/server/deployment.yaml#L105 - it may be nice in many cases to pull env vars from secrets rather than pass them through Helm values. (i.e. |
674cab3 to
de59237
Compare
Support GCP credentials for external cloud provider workloads Co-authored-by: saisatish karra <[email protected]> Signed-off-by: Wayne Starr <[email protected]>
Co-authored-by: saisatish karra <[email protected]> Signed-off-by: Wayne Starr <[email protected]>
Co-authored-by: saisatish karra <[email protected]> Signed-off-by: Wayne Starr <[email protected]>
Co-authored-by: saisatish karra <[email protected]> Signed-off-by: Wayne Starr <[email protected]>
Signed-off-by: Wayne Starr <[email protected]>
Signed-off-by: Wayne Starr <[email protected]>
de59237 to
a2f7ddf
Compare
|
(would also like to make a similar change to the |
|
How do I vote up on this. Fulcio needs to set envs to get client_id and secret. Or can I pick up this somehow |
Description of the change
Support GCP credentials for external cloud provider workloads and add additional env vars for specifying values like
VAULT_ADDRExisting or Associated Issue(s)
This is a repickup of #530
Additional Information
Checklist
Chart.yamlaccording to semver. Where applicable, update and bump the versions in any associated umbrella chartvalues.yamland added to the README.md. The helm-docs utility can be used to generate the necessary content. Usehelm-docs --dry-runto preview the content.ct lintcommand.