Skip to content

Unsubscribe only when Dispose() is called #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
papeh wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Unsubscribe only when Dispose() is called #656

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions Src/xWorks/xWorksTests/DictionaryConfigurationMigrators/StubContentControlProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright (c) 2016 SIL International
// Copyright (c) 2016-2026 SIL International
// This software is licensed under the LGPL, version 2.1 or later
// (http://www.gnu.org/licenses/lgpl-2.1.html)using System;

Expand Down Expand Up @@ -91,8 +91,8 @@ private void GetContentControlParameters(object parameterObj)
result[0] = param.Item2 == "lexiconDictionary" ? m_testControlDictNode : m_testControlRevNode;
}

public bool ShouldNotCall { get { return false; } }
public int Priority { get { return 1; }}
public bool ShouldNotCall => false;
public int Priority => 1;

public void Dispose()
{
Expand All @@ -103,7 +103,11 @@ public void Dispose()
public void Dispose(bool disposeCalled)
{
System.Diagnostics.Debug.WriteLineIf(!disposeCalled, "****** Missing Dispose() call for " + GetType().Name + ". ****** ");
Subscriber.Unsubscribe(EventConstants.GetContentControlParameters, GetContentControlParameters);

if (disposeCalled)
{
Subscriber.Unsubscribe(EventConstants.GetContentControlParameters, GetContentControlParameters);
}
}

~StubContentControlProvider()
Expand Down
Loading