Conversation
- Add migration to create patient_scores table (with existence check) - Add PatientScore model with Mergeable concern - Add Api::V4::PatientScoresController with sync_to_user only - Add PatientScoreTransformer for response transformation - Add patient_score schema to Api::V4::Models - Add GET route for /patient_scores/sync - Add factory and controller spec for patient_scores (sync_to_user only)
…t line 9724, which terminated the INSERT INTO schema_migrations statement early. The migration versions on lines 9725-9729 were left as orphaned SQL, causing the syntax error.
- Added filter_enabled? method that checks Flipper.enabled?(:patient_deduplication_filter, current_admin) - before_action :set_filter_options now only runs if filter is enabled - Filter logic in show action is conditional on feature flag
|
Could you please update the PR description with what this PR actually does? Thanks |
|
This PR is stale. Please review/update it or close it. |
igbanam
left a comment
igbanam
left a comment
There was a problem hiding this comment.
From what I gather looking through implementation here, it looks like we are trying to vend the patient_scores resource to the mobile somehow. If this is why we are doing this, please update the PR description and the JIRA ticket so it's clear.
A couple comments
- I think a simple GET endpoint will suffice here. Patient Scores don't need to be sync'd from the field. Think of it as a "materialized view" of sorts from data collected from the field.
- If you've been instructed to do this as a sync route, please do two things (1) document that instruction somewhere so future collaborators can understand the decision path here, and (2) fix the link to patients, because that causes an order bug.
| # Apply facility filter if selected and feature flag is enabled | ||
| filtered_facilities = if filter_enabled? && @selected_facility.present? | ||
| facilities.where(id: @selected_facility.id) | ||
| elsif filter_enabled? && @selected_district.present? | ||
| facilities.where(id: @selected_district.facilities) | ||
| else | ||
| facilities | ||
| end | ||
|
|
There was a problem hiding this comment.
Do we still need #5789 if we have this here as well?
| scope :patient_scores do | ||
| get "sync", to: "patient_scores#sync_to_user" | ||
| end |
There was a problem hiding this comment.
Why do we need a sync route for this? PatientScore is not data we collect from the field per se; it's calculated from the data collected. A simple GET route would suffice here. Am I missing something?
| def change | ||
| unless table_exists?(:patient_scores) | ||
| create_table :patient_scores, id: :uuid do |t| | ||
| t.references :patient, null: false, foreign_key: true, type: :uuid |
|
Oh and there's significant overlap with #5789. You may want to look into that |
2 participants
Story card: sc-XXXX
Because
Enter the reason for raising this PR...
This addresses
Enter the details of what all this covers...
Test instructions
Enter detailed instructions for how to test this PR...