Skip to content

Commit 982ceb5

Browse files
committed
docs(desktop): record why access-denied reserving is not a double reservation
Review read `WorkspaceHostProvider` as rendering the denied page inside the chrome. It is the other way round: the provider wraps `<WorkspaceChrome>` in the layout, and its 403 branch returns the denied page instead of its children, so the chrome never mounts. The server-side early return does the same thing higher up. Both paths therefore bypass the chrome and the page's own reservation is the only one. Recording that next to the entry, since the file lives under a workspace path where inherited coverage is the norm and the reading is an easy one to repeat.
1 parent 3c4768b commit 982ceb5

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

apps/sim/app/_shell/desktop-title-bar-surfaces.test.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -270,6 +270,10 @@ const isExempt = (file: string) =>
270270
* tree, so its inherited coverage is real.
271271
*/
272272
const SELF_RESERVE_REQUIRED = new Set([
273+
// Both of its render paths bypass the chrome, so its own reservation is the only one:
274+
// `layout.tsx` returns it before reaching `<WorkspaceChrome>`, and
275+
// `WorkspaceHostProvider` — an ancestor of the chrome, not a descendant — returns it
276+
// instead of its children on a client-side 403. Neither is a double reservation.
273277
'app/workspace/[workspaceId]/components/workspace-access-denied.tsx',
274278
])
275279

0 commit comments

Comments
 (0)