fix(atlassian): resolve Jira and Confluence selector contexts server-side - #7122
Open
BillLeoutsakosvl346 wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
10 tasks
BillLeoutsakosvl346
force-pushed
the
fix/server-resolved-selector-context
branch
from
August 26, 2026 22:25
fafded6 to
0486f57
Compare
BillLeoutsakosvl346
force-pushed
the
fix/server-resolved-atlassian-selectors
branch
from
August 26, 2026 22:25
bbba262 to
1f04f40
Compare
BillLeoutsakosvl346
force-pushed
the
fix/server-resolved-selector-context
branch
from
August 26, 2026 23:28
0486f57 to
17726cb
Compare
BillLeoutsakosvl346
force-pushed
the
fix/server-resolved-atlassian-selectors
branch
from
August 26, 2026 23:28
1f04f40 to
b93f8b5
Compare
BillLeoutsakosvl346
marked this pull request as ready for review
August 26, 2026 23:32
Contributor
Greptile SummaryThe PR moves Jira and Confluence selector context and credential resolution to authenticated server routes while preserving raw environment references in browser requests.
Confidence Score: 5/5The PR appears safe to merge because no blocking failure remains. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| apps/sim/app/api/tools/confluence/selector-page/route.ts | Adds an authenticated server endpoint that resolves Confluence selector context and returns sanitized page details. |
| apps/sim/app/api/tools/confluence/selector-pages/route.ts | Adds server-side credential and context resolution for Confluence page option discovery. |
| apps/sim/app/api/tools/confluence/selector-spaces/route.ts | Migrates space discovery to the authorized selector context and credential helpers with sanitized provider failures. |
| apps/sim/app/api/tools/jira/issues/route.ts | Replaces browser-provided Jira tokens and cloud IDs with authenticated server-side resolution for issue selectors. |
| apps/sim/app/api/tools/jira/projects/route.ts | Migrates project discovery and detail lookup to server-resolved credentials and reduced response mappings. |
| apps/sim/hooks/selectors/providers/confluence/selectors.ts | Sends raw domain references and credential IDs to dedicated Confluence selector routes without exposing OAuth tokens. |
| apps/sim/hooks/selectors/providers/jira/selectors.ts | Opts Jira selectors into server-resolved domain context and updates their request and option mappings. |
| apps/sim/lib/api/contracts/selectors/confluence.ts | Defines credential-backed Confluence selector request contracts for server-side context resolution. |
| apps/sim/lib/api/contracts/selectors/jira.ts | Updates Jira selector wire contracts to accept credential IDs, raw domains, and optional workflow IDs. |
Sequence Diagram
sequenceDiagram
participant Browser
participant Route as Atlassian Selector Route
participant Context as Authorized Context Resolver
participant Credential as Credential Resolver
participant Atlassian
Browser->>Route: Raw domain reference + credential ID + optional workflow ID
Route->>Context: Authenticate and resolve authorized context
Context-->>Route: Resolved domain and credential owner
Route->>Credential: Resolve service-bound credential
Credential-->>Route: Access token and optional cloud ID
Route->>Atlassian: Fetch selector options
Atlassian-->>Route: Provider response
Route-->>Browser: Sanitized option data or stable error
Reviews (2): Last reviewed commit: "fix(atlassian): resolve Jira and Conflue..." | Re-trigger Greptile
BillLeoutsakosvl346
force-pushed
the
fix/server-resolved-selector-context
branch
from
August 27, 2026 00:17
17726cb to
aeaa7ec
Compare
BillLeoutsakosvl346
force-pushed
the
fix/server-resolved-atlassian-selectors
branch
from
August 27, 2026 00:17
b93f8b5 to
b002e19
Compare
BillLeoutsakosvl346
force-pushed
the
fix/server-resolved-atlassian-selectors
branch
from
August 27, 2026 00:31
b002e19 to
48f748e
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{{KEY}}references in browser requests while keeping resolved environment values server-only.Security behavior
{{KEY}}refetches without exposing its value.Focused coverage
Verification
git diff --checkpassed on the combined stack.Browser verification