chore(lint): delete unused variables and parameters; enforce both rules repo-wide by waleedlatif1 · Pull Request #8554 · simstudioai/sim

waleedlatif1 · 2026-10-02T00:42:45Z

Summary

Delete every unused variable and function parameter across apps (~495 variables, ~167 parameters), ~230 dead private interfaces/types, unused loggers, and catch (e) bindings → catch {}
Remove the unused BlockConfig<T> type parameter (it never appeared in the interface body); blocks now write plain BlockConfig as the skills already say
Enforce noUnusedVariables and noUnusedFunctionParameters as errors repo-wide with fix: "none" so bun run lint's unsafe autofix can't silently _-prefix bindings; ignoreRestSiblings keeps the const { a, ...rest } omit idiom. Redundant packages/** override removed
_ prefixes remain only on parameters that must hold their position (route handlers using a later arg, connector/tool callbacks); no biome-ignore
Side-effecting calls kept with the binding dropped (e.g. draining a Teams response body to release the connection, an authorization execute whose result was unused)
CLAUDE.md gets the matching rule; CONTRIBUTING's block example updated

Type of Change

Chore / refactor (no intended behavior change)

Testing

bun run lint, bunx turbo run type-check, bun run check:audits, root bun run test (test:scripts + every workspace suite)
Three independent audits re-checked every removed parameter's callers repo-wide (no positional shifts), every dropped initializer for side effects, and test tables; 264 of 384 block/tool files transpile to byte-identical JS (type-only changes)

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing (new tests pass the test-audit authoring gate)
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

🤖 Generated with Claude Code

vercel · 2026-10-02T00:42:49Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
docs	Ready	Preview	Oct 2, 2026 1:58am UTC

greptile-apps · 2026-10-02T00:47:41Z

Confidence Score: 5/5

[Medium risk] Removes unused variables and parameters across the codebase.

The PR appears safe to merge based on the findings established in this review.

Summary

The PR enforces unused-binding lint rules and removes unused declarations across the repository. Changes since the previous review also add workflow-version comparison across the API and editor, and revise workspace-file provenance handling.

The earlier form-cache finding is fixed.
The four earlier any findings were withdrawn after the pre-existing annotations were confirmed.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[Version comparison request] --> B[Workflow read authorization]
  B --> C[Load and materialize snapshots]
  C --> D[Compute semantic diff]
  D --> E[Redact public values]
  E --> F[API response]

_{Reviews (4) · Last reviewed commit: "fix(resume): update the per-context form..."}

cubic-dev-ai

All reported issues were addressed across 682 files

_{Note: This PR contains a large number of files. cubic selects up to 200 of the highest-priority eligible files for this review, so some files may not have been reviewed.

Fix all with cubic | Re-trigger cubic}

waleedlatif1 · 2026-10-02T00:57:49Z

@greptile

waleedlatif1 · 2026-10-02T00:57:51Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-02T00:57:58Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 682 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Note: This PR contains a large number of files. cubic selects up to 200 of the highest-priority eligible files for this review, so some files may not have been reviewed.

Re-trigger cubic}

waleedlatif1 · 2026-10-02T01:17:36Z

@greptile

waleedlatif1 · 2026-10-02T01:17:38Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-02T01:17:46Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 682 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Note: This PR contains a large number of files. cubic selects up to 200 of the highest-priority eligible files for this review, so some files may not have been reviewed.

Re-trigger cubic}

waleedlatif1 · 2026-10-02T01:34:39Z

@greptile

…used loggers

Remove dead locals, constants, helpers, test mock aliases, and unused function parameters (updating callers), drop the unused BlockConfig type parameter and the response types that only fed it.

…meters repo-wide Enable both rules as errors at the root with no autofix, so bun run lint never mass-renames bindings to _x, and ignoreRestSiblings so the { a, ...rest } omit idiom stays legal. The packages/** override is now redundant and removed. Document the rule in CLAUDE.md.

…tale run-options note

waleedlatif1 · 2026-10-02T01:55:44Z

@greptile

waleedlatif1 · 2026-10-02T01:55:46Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-02T01:55:55Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 681 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Note: This PR contains a large number of files. cubic selects up to 200 of the highest-priority eligible files for this review, so some files may not have been reviewed.

Re-trigger cubic}

vercel Bot deployed to Preview October 2, 2026 00:45 View deployment

waleedlatif1 mentioned this pull request Oct 2, 2026

v0.9.10: geo, chat fixes, sandbox fixes #8539

Merged

greptile-apps Bot reviewed Oct 2, 2026

View reviewed changes

Comment thread apps/sim/app/(interfaces)/resume/[workflowId]/[executionId]/resume-page-client.tsx Outdated

cubic-dev-ai Bot reviewed Oct 2, 2026

View reviewed changes

Comment thread apps/sim/app/(interfaces)/resume/[workflowId]/[executionId]/resume-page-client.tsx Outdated

vercel Bot temporarily deployed to Preview October 2, 2026 00:57 Inactive

cubic-dev-ai Bot reviewed Oct 2, 2026

View reviewed changes

waleedlatif1 force-pushed the improvement/unused-variables branch from f869f90 to 5f74ccd Compare October 2, 2026 01:17

vercel Bot deployed to Preview October 2, 2026 01:19 View deployment

cubic-dev-ai Bot reviewed Oct 2, 2026

View reviewed changes

greptile-apps Bot reviewed Oct 2, 2026

View reviewed changes

Comment thread apps/sim/executor/handlers/workflow/workflow-handler.test.ts

Comment thread apps/sim/lib/pptx-renderer/renderer/chart-renderer.ts

Comment thread apps/sim/tools/index.test.ts

Comment thread apps/sim/tools/kalshi/types.ts

waleedlatif1 added 5 commits October 1, 2026 18:53

chore(lint): remove unused catch bindings, dead private types, and un…

d69d3da

…used loggers

chore(lint): delete unused variables and parameters across apps

640c68d

Remove dead locals, constants, helpers, test mock aliases, and unused function parameters (updating callers), drop the unused BlockConfig type parameter and the response types that only fed it.

docs: drop BlockConfig type argument from contributing example; fix s…

37be210

…tale run-options note

fix(resume): update the per-context form cache outside the state updater

75815d0

waleedlatif1 force-pushed the improvement/unused-variables branch from 5f74ccd to 75815d0 Compare October 2, 2026 01:55

cubic-dev-ai Bot reviewed Oct 2, 2026

View reviewed changes

vercel Bot deployed to Preview October 2, 2026 01:58 View deployment

waleedlatif1 merged commit e3211dd into staging Oct 2, 2026
36 checks passed

waleedlatif1 deleted the improvement/unused-variables branch October 2, 2026 06:42

Conversation

waleedlatif1 commented Oct 2, 2026

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Oct 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps Bot commented Oct 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

waleedlatif1 commented Oct 2, 2026

Uh oh!

waleedlatif1 commented Oct 2, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 2, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

waleedlatif1 commented Oct 2, 2026

Uh oh!

waleedlatif1 commented Oct 2, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 2, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

waleedlatif1 commented Oct 2, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Oct 2, 2026

Uh oh!

waleedlatif1 commented Oct 2, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 2, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vercel Bot commented Oct 2, 2026 •

edited

Loading

greptile-apps Bot commented Oct 2, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading