Skip to content

fix(cli): report authentication accurately and preserve file text - #8555

Merged
icecrasher321 merged 2 commits into
stagingfrom
codex/cli-diagnostics
Oct 2, 2026
Merged

icecrasher321 merged 2 commits into
stagingfrom
codex/cli-diagnostics

Conversation

@icecrasher321

@icecrasher321 icecrasher321 commented Oct 2, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Verify whoami credentials through the existing metadata endpoint even without a workspace. Report authentication separately from workspace access: true when accepted, false when missing or rejected, and null when unchecked or unavailable. Preserve existing verification statuses, exit codes, and the workspace fallback for older servers or malformed metadata.
  • Render current and versioned file text through the existing document output so table/text modes retain the complete response. Keep server extraction warnings and JSON/YAML metadata intact.
  • Keep the credential-lock test independent of acquisition order while still enforcing serialization and release.
  • Document the existing-folder prerequisite and sim workflows mkdir command in workflow creation help; regenerate CLI docs.

Type of Change

  • Bug fix

Testing

  • Full CLI suite: 464 tests across 52 files passed.
  • Regression tests failed before the fixes; seven individual negative controls also failed as expected, then passed after restoration.
  • Built Node CLI: 25 subprocess checks over loopback HTTP passed, covering authentication verdicts, workspace access, older servers, file content, truncation warnings, and folder help. Local JSON reports capture outputs, requests, statuses, and durations; these checks use controlled API responses rather than a deployed backend.
  • CLI type check and build passed.
  • Repository lint, all 55 audits, staging-based block registry check, and docs manifest check passed. Lint retained one pre-existing warning in scripts/generate-docs.test.ts.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Oct 2, 2026 1:30am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium risk] CLI authentication reporting and file text output behavior.

The PR appears safe to merge; no outstanding finding or new actionable issue was identified.

Summary

The PR separates credential authentication from workspace verification, preserves complete file text in displayed output, clarifies workflow folder help, and updates tests and generated documentation.

  • The previously reported no-workspace diagnostic is restored and its thread is resolved.

Reviews (2) · Last reviewed commit: "fix(cli): preserve whoami compatibility ..."

Comment thread packages/sim-cli/src/commands/auth.ts Outdated

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 8 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread packages/sim-cli/src/commands/auth.ts Outdated
Comment thread packages/sim-cli/src/commands/auth.ts Outdated
@icecrasher321

Copy link
Copy Markdown
Collaborator Author

@greptile

@icecrasher321

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@icecrasher321 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 9 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@icecrasher321
icecrasher321 merged commit 401e039 into staging Oct 2, 2026
33 of 34 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/cli-diagnostics branch October 2, 2026 06:42

This branch was previously deployed

1 inactive deployment
Preview — 225a854f Deployed Oct 2, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant