[Gear] Vaelgors final stare trinket

[NN0323]

No description provided.

[nyterage]

Few issues here which will mean its not properly modeled for sims

[nyterage]

Looks like you've got the incorrect spell id for the value here, should be 1259293 (the driver spell)

[NN0323]

The driver spell does not have an effectN(3) and the duration and periodic damage is specified in nullsight it might be that i dont fully understand what the driver spell truly is the way its currently implemented works from what ive tested give an initial mastery buff for x amount then ticks down x/ticks amounts every tick = 1 second for 15 seconds

[nyterage]

so, when talking about the "value" for items like these, we do mean the spell that contains the coefficient and scaled value.

in the case of this trinket it would be

Name             : Vaelgor's Final Stare (id=1259293) [Passive] 
School           : Physical
Spell Type       : None
Labels           : 292
                 : 3959: Item Effects
Attributes       : Passive (6), No Aura Icon (60), Can Proc From Procs (122), No Aura Log (202), Aura Points On Client (268), Scales with Casting Item's Level (354)
Effects          :
#1 (id=1268341)  : Apply Aura (6) | Dummy (4) | Scaling Class: Secondary Rating (-7)
                   Base Value: 0 | Scaled Value: 755.1957 (coefficient=5.761313) | PvP Coefficient: 0.5 | Target: Self (1)

This spell contains the buffs value. While the other 3 data pieces youre looking for are in the buff spell themselves. That buff spell wont need the second lookup since its already the struct youre in, and can instead be called with data().x

so, this ctor should end up something like

auto n_ticks = data().duration() / data().effectN( 3 ).period();
buff_val     = e.driver()->effectN( 1 ).average( e );
decrease     = buff_val / n_ticks;
set_stat_from_effect( 1, buff_val );
set_tick_callback( [ this ]( buff_t*, int, timespan_t ) { recalculate(); } );

[nyterage]

Codestyle issue here, should be nullsight_t