Skip to content

[Warlock] Destruction apex talent#10983

Merged
nyterage merged 2 commits intosimulationcraft:midnightfrom
stahlscott:midnight-warlock-apex-talents
Feb 19, 2026
Merged

[Warlock] Destruction apex talent#10983
nyterage merged 2 commits intosimulationcraft:midnightfrom
stahlscott:midnight-warlock-apex-talents

Conversation

@stahlscott
Copy link
Contributor

Initial implementation of Embers of Nihilam apex talent for warlock destruction spec

Needs verification:

  • Rank 1 proc rate (Incinerate → Echo of Sargeras) is not in spell data: using 25% placeholder, configurable via rng_settings

Implementation notes:

  • Visions of Nihilam (rank 2/3) scaling: spell data auto-scales base_value with talent rank via op=mul, values=(1,2), so .percent() alone gives the correct value (4% at rank 1, 8% at rank 2)
  • Rank 4 uses a helper for all affected spells (CB, SB, RoF) to handle the case where there's no target present - even though CB/SB always has a target as of now, figured it was safer for future proofing
  • Rank 1 (proc chance, no ICD) and rank 3 (guaranteed, 0.5s ICD) are intentionally independent as they are separate talent effects with different gating mechanics

@stahlscott stahlscott changed the title [Warlock] Embers of Nihilam implementation [Warlock] Destruction apex talent Feb 19, 2026
Copy link
Member

@nyterage nyterage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good generally, only one comment

@nyterage nyterage merged commit 9eb1958 into simulationcraft:midnight Feb 19, 2026
164 of 225 checks passed
@stahlscott stahlscott deleted the midnight-warlock-apex-talents branch February 20, 2026 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments