Skip to content

[Rogue] adjust Fazed secondary effects scaling with stacks #11429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seanpeters86 merged 2 commits into from
May 2, 2026
+18 −2
Merged

[Rogue] adjust Fazed secondary effects scaling with stacks #11429

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78e8d2c
[Rogue] adjust Fazed secondary effects scaling with stacks
seanpeters86 May 2, 2026
2cd398b
use an option
seanpeters86 May 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions engine/class_modules/sc_rogue.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1104,6 +1104,7 @@ class rogue_t : public player_t
bool rogue_ready_trigger = true;
bool priority_rotation = false;
double the_first_dance_trigger_rate = 0.75;
bool trickster_cloud_cover_secondary = true;
} options;

rogue_t( sim_t* sim, util::string_view name, race_e r = RACE_NIGHT_ELF ) :
Expand Down Expand Up @@ -2506,7 +2507,14 @@ class rogue_action_t : public Base

if ( affected_by.fazed_crit_chance && td( target )->debuffs.fazed->check() )
{
c += td( target )->debuffs.fazed->stack_value_crit_chance();
if ( p()->options.trickster_cloud_cover_secondary )
{
c += td( target )->debuffs.fazed->stack_value_crit_chance();
}
else
{
c += td( target )->debuffs.fazed->value_crit_chance();
}
}

return c;
Expand Down Expand Up @@ -2564,7 +2572,13 @@ class rogue_action_t : public Base

if ( affected_by.fazed_crit_damage )
{
cm *= 1.0 + p()->talent.trickster.surprising_strikes->effectN( 1 ).percent() * td( target )->debuffs.fazed->check();
if ( p()->options.trickster_cloud_cover_secondary )
{
cm *= 1.0 + p()->talent.trickster.surprising_strikes->effectN( 1 ).percent() * td( target )->debuffs.fazed->check(); }
else
{
cm *= 1.0 + p()->talent.trickster.surprising_strikes->effectN( 1 ).percent() * td( target )->debuffs.fazed->up();
}
}

return cm;
Expand Down Expand Up @@ -10980,6 +10994,7 @@ void rogue_t::create_options()
add_option( opt_func( "fixed_rtb_odds", parse_fixed_rtb_odds ) );
add_option( opt_bool( "priority_rotation", options.priority_rotation ) );
add_option( opt_float( "the_first_dance_trigger_rate", options.the_first_dance_trigger_rate, 0, 1 ) );
add_option( opt_bool( "trickster_cloud_cover_secondary", options.trickster_cloud_cover_secondary ) );
}

// rogue_t::copy_from =======================================================
Expand Down Expand Up @@ -11009,6 +11024,7 @@ void rogue_t::copy_from( player_t* source )
options.fixed_rtb_odds = rogue->options.fixed_rtb_odds;
options.rogue_ready_trigger = rogue->options.rogue_ready_trigger;
options.priority_rotation = rogue->options.priority_rotation;
options.trickster_cloud_cover_secondary = rogue->options.trickster_cloud_cover_secondary;

options.the_first_dance_trigger_rate = rogue->options.the_first_dance_trigger_rate;
}
Expand Down