[Warlock] Move crit-based bonus damage to composite_da_multiplier

[millanzarreta]

The Warlock has several spells that gain a bonus damage based on the player’s base critical strike chance. In SimC, this damage was being applied in calculate_direct_amount instead of composite_da_multiplier, which was not conceptually correct. The necessary changes have been made to move this crit-based bonus damage to the appropriate place.

For spells without travel time, the final result is the same in both cases. However, applying the damage modifier in composite_da_multiplier is more correct, and also allows the damage modifier to be properly shown in debug logs.

For spells with travel time, composite_da_multiplier is applied during execute(), while calculate_direct_amount is applied on impact(), which is conceptually different. In-game, this damage bonus is calculated on execute(): this was tested using a trinket that grants a large critical strike chance bonus after execute() but before impact(), and the impact damage was not affected by the trinket. This reinforces that, like most spell damage modifiers, this crit-based damage bonus is snapshotted at execute() rather than on impact.