[Warlock] Refine target filtering for several spells#11439
Merged
nyterage merged 2 commits intosimulationcraft:midnightfrom May 5, 2026
Merged
[Warlock] Refine target filtering for several spells#11439nyterage merged 2 commits intosimulationcraft:midnightfrom
nyterage merged 2 commits intosimulationcraft:midnightfrom
Conversation
…er_callback for simple filters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several changes to the Warlock module related to targeting for some spells:
target_filter_callbackfor simple filtersrange::erase_removeinstead of removing entries one by one with awhileloop in several places.CorruptionorWitherDoT applied. This behavior was not previously implemented in sims and has now been added in this PR.init()function, it is more correct to callaction_base_t::init()(the immediate parent ofwarlock_spell_t) rather thanspell_t::init(). A comment has also been added to clarify thatwarlock_spell_t::init()is intentionally not called, because the purpose of this override is to replace its behavior.ready()function has been adjusted to match that behavior.