-
Notifications
You must be signed in to change notification settings - Fork 686
feat(socket-mode): support undici v8 as a peer dependency #2694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
WilliamBergamin
wants to merge
9
commits into
main
Choose a base branch
from
expand-undici-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+60
−13
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
cd68c2b
feat(socket-mode): support undici v8 as a peer dependency
WilliamBergamin 7edc776
docs(ci): condense undici install step comment to one line
WilliamBergamin 4cabd4a
docs(ci): trim undici install step comment
WilliamBergamin 3e6270d
test(socket-mode): simplify undici version guardrail test
WilliamBergamin 7473bef
Merge branch 'main' into expand-undici-support
WilliamBergamin 42ac8ba
Merge branch 'main' into expand-undici-support
WilliamBergamin f1decb9
Merge branch 'main' into expand-undici-support
WilliamBergamin 7471105
Merge branch 'main' into expand-undici-support
WilliamBergamin c0746b2
Apply suggestion from @zimeg
WilliamBergamin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@slack/socket-mode": minor | ||
| --- | ||
|
|
||
| Support `undici@^8` as a peer dependency in addition to `undici@^7`. `undici@^8` requires Node.js >=22.19; `undici@^7` continues to support Node.js >=20. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| import assert from 'node:assert/strict'; | ||
| import { createRequire } from 'node:module'; | ||
| import { describe, it } from 'node:test'; | ||
|
|
||
| // Guardrail for the `undici` peer dependency. undici v8 needs | ||
| // Node >=22 and v7 needs Node >=20, so CI passes the expected major in via SOCKET_MODE_UNDICI_VERSION. | ||
|
|
||
| const require = createRequire(import.meta.url); | ||
| const undiciVersion: string = require('undici/package.json').version; | ||
| const undiciMajor = Number.parseInt(undiciVersion.split('.')[0], 10); | ||
| const nodeMajor = Number.parseInt(process.versions.node.split('.')[0], 10); | ||
|
|
||
| describe('undici peer dependency', () => { | ||
| it('never runs undici v8+ on Node older than 22', () => { | ||
| assert.ok( | ||
| undiciMajor >= 8 && nodeMajor < 22, | ||
| `undici@${undiciVersion} requires Node >=22, but tests are running on Node ${process.versions.node}`, | ||
| ); | ||
| }); | ||
|
|
||
| const expectedMajor = process.env.SOCKET_MODE_UNDICI_VERSION; | ||
| if (expectedMajor) { | ||
| it(`runs against the undici major pinned by CI (v${expectedMajor})`, () => { | ||
| assert.strictEqual( | ||
| undiciMajor, | ||
| Number.parseInt(expectedMajor, 10), | ||
| `Expected undici v${expectedMajor} (SOCKET_MODE_UNDICI_VERSION), but undici@${undiciVersion} is installed`, | ||
| ); | ||
| }); | ||
| } else { | ||
| it.skip('runs against the undici major pinned by CI (only when SOCKET_MODE_UNDICI_VERSION is set)'); | ||
| } | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 praise: Thanks for keeping support consistent!