Skip to content

fix: resolve OAuth installation store bugs and typos #1864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WilliamBergamin merged 4 commits into from
Apr 29, 2026
Merged

fix: resolve OAuth installation store bugs and typos #1864

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0b14ab1
fix: resolve OAuth installation store bugs and typos
WilliamBergamin Apr 28, 2026
f4b2628
clean up changes
WilliamBergamin Apr 28, 2026
ecb61e5
Update __init__.py
WilliamBergamin Apr 28, 2026
42603cb
Merge branch 'main' into oauth-installation-store-bugs
WilliamBergamin Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions slack_sdk/oauth/installation_store/amazon_s3/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ def save(self, installation: Installation):

def save_bot(self, bot: Bot):
if bot.bot_token is None:
self.logger.debug("Skipped saving a new row because of the absense of bot token in it")
self.logger.debug("Skipped saving a new row because of the absence of bot token in it")
return

none = "none"
Expand Down Expand Up @@ -273,7 +273,7 @@ def delete_bot(self, *, enterprise_id: Optional[str], team_id: Optional[str]) ->
Key=content.get("Key"),
)
except Exception as e:
message = f"Failed to find bot installation data for enterprise: {e_id}, team: {t_id}: {e}"
message = f"Failed to delete bot installation data for enterprise: {e_id}, team: {t_id}: {e}"
raise SlackClientConfigurationError(message)

async def async_delete_installation(
Expand Down Expand Up @@ -316,7 +316,7 @@ def delete_installation(
)
deleted_keys.append(key)
except Exception as e:
message = f"Failed to find bot installation data for enterprise: {e_id}, team: {t_id}: {e}"
message = f"Failed to delete installation data for enterprise: {e_id}, team: {t_id}: {e}"
raise SlackClientConfigurationError(message)

try:
Expand All @@ -328,7 +328,7 @@ def delete_installation(
)
deleted_keys.append(no_user_id_key)
except Exception as e:
message = f"Failed to find bot installation data for enterprise: {e_id}, team: {t_id}: {e}"
message = f"Failed to delete installation data for enterprise: {e_id}, team: {t_id}: {e}"
raise SlackClientConfigurationError(message)

# Check the remaining installation data
Expand All @@ -347,5 +347,5 @@ def delete_installation(
Key=content.get("Key"),
)
except Exception as e:
message = f"Failed to find bot installation data for enterprise: {e_id}, team: {t_id}: {e}"
message = f"Failed to delete installation data for enterprise: {e_id}, team: {t_id}: {e}"
raise SlackClientConfigurationError(message)
3 changes: 2 additions & 1 deletion slack_sdk/oauth/installation_store/async_cacheable_installation_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,8 @@ async def async_delete_bot(
team_id=team_id,
)
key = f"{enterprise_id or ''}-{team_id or ''}"
self.cached_bots.pop(key)
if key in self.cached_bots:
self.cached_bots.pop(key)

async def async_delete_installation(
self,
Expand Down
2 changes: 1 addition & 1 deletion slack_sdk/oauth/installation_store/file/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ def save(self, installation: Installation):

def save_bot(self, bot: Bot):
if bot.bot_token is None:
self.logger.debug("Skipped saving a new row because of the absense of bot token in it")
self.logger.debug("Skipped saving a new row because of the absence of bot token in it")
return

none = "none"
Expand Down
2 changes: 1 addition & 1 deletion slack_sdk/oauth/installation_store/sqlite3/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ def save(self, installation: Installation):

def save_bot(self, bot: Bot):
if bot.bot_token is None:
self.logger.debug("Skipped saving a new row because of the absense of bot token in it")
self.logger.debug("Skipped saving a new row because of the absence of bot token in it")
return

with self.connect() as conn:
Expand Down