Repository navigation
ci: ignore zizmor self-repository warnings in testing workflows - #714
Conversation
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #714 +/- ##
=======================================
Coverage 99.86% 99.86%
=======================================
Files 8 8
Lines 732 732
=======================================
Hits 731 731
Misses 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
cchensh
left a comment
There was a problem hiding this comment.
On your $/cli question: I'd keep ./cli with the same inline # zizmor: ignore[self-repository] you used on ./, for now.
$/cli loads the action from the commit the workflow runs on, not from the checkout. The CLI jobs check out inputs.ref || github.event.pull_request.head.sha || github.sha (integration.yml:287). So:
- A maintainer dispatch with
ref: pull/N/headfor a fork PR would test main'scli/action.ymlagainst the fork's files. - On
pull_requestruns,$/is the merge commit rather than the head SHA. - The API steps still use
./from the checkout, so a single run would mix two versions of the repo.
The rest looks good: the ignore comments don't change any step, the needs: move in release.yml is cosmetic, and keeping push credentials on the release.yml checkouts is right.
mwbrooks
left a comment
There was a problem hiding this comment.
+1 to @cchensh on $/cli: a maintainer-dispatched run for a fork PR would test main's cli/action.yml, so a fork change to it could pass without being tested. Keeping ./cli with the same ignore as ./ works for me. Happy to approve once that's in!
WilliamBergamin
left a comment
There was a problem hiding this comment.
🧪 Thanks @zimeg! Keeping ./ for the steps that run the built dist/ while still silencing zizmor is a tidy way to clear the audit without touching test behavior.
One blocking comment on $/cli, the same ask as the earlier reviews, the rest is optional 🙏
Co-authored-by: William Bergamin <25348381+WilliamBergamin@users.noreply.github.com> Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
cchensh
left a comment
There was a problem hiding this comment.
Re-checked at 8c15f11e: all four CLI steps are back on ./cli with the inline self-repository ignore, so they test the checked-out ref. No $/ is left, and every in-repo uses: across .github/workflows/ carries the ignore. The diff is now only ignore comments plus the publish key reorder, which the description notes. CLI tests (all three OSes), API, unit tests and CodeQL are green.
|
🌟 Thanks for the kind reviews @cchensh, @mwbrooks and @WilliamBergamin! Keeping |
Summary
This pull request ignores zizmor
self-repositorywarnings in the testing workflows sozizmor .githubpasses without changing workflow behavior.if:ahead ofneeds:on thepublishjob inrelease.ymlso job keys readif,runs-on,needs,permissions,stepslike the other jobs. This follows the job key order we use across our workflows and doesn't clear a zizmor finding.uses: ./anduses: ./cliwith an inline# zizmor: ignore[self-repository]on the 24 in-repo steps indevelop.ymlandintegration.yml.$/loads the repo at the commit the workflow runs on, so it skips thedist/built during the run (File not found: .../dist/index.js) and a maintainer dispatch for a fork PR would testmain'scli/action.ymlinstead of the checked outref. Changing those tests so$/works is saved for a follow-up.permissions:, and checkouts usepersist-credentials: falseexcept the two inrelease.ymlthat push.Questions for review:
release.ymlcheckouts keeppersist-credentials: truesincechangesets/actionand the release step push withgit. Okay to leave as-is?Testing
zizmor .githubreports no findings, in both offline mode and with a GitHub token, now that ci: check Dependabot updates daily with a 7 day cooldown #713 is merged into this branch..github/workflows/parses withjs-yaml.$/for every step: the CLI tests passed and the API tests failed on the missingdist/index.js.--persona=pedanticfindings (workflow-levelpermissions,concurrency, permission comments, and the fork notice inintegration.yml) are unchanged.Requirements
🤖 Generated with Claude Code