Skip to content

ci: ignore zizmor self-repository warnings in testing workflows - #714

Merged
zimeg merged 6 commits into
mainfrom
zimeg-ci-zizmor-audit
Nov 20, 2026
Merged

zimeg merged 6 commits into
mainfrom
zimeg-ci-zizmor-audit

Conversation

@zimeg

@zimeg zimeg commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

Summary

This pull request ignores zizmor self-repository warnings in the testing workflows so zizmor .github passes without changing workflow behavior.

  • Moves if: ahead of needs: on the publish job in release.yml so job keys read if, runs-on, needs, permissions, steps like the other jobs. This follows the job key order we use across our workflows and doesn't clear a zizmor finding.
  • Keeps uses: ./ and uses: ./cli with an inline # zizmor: ignore[self-repository] on the 24 in-repo steps in develop.yml and integration.yml. $/ loads the repo at the commit the workflow runs on, so it skips the dist/ built during the run (File not found: .../dist/index.js) and a maintainer dispatch for a fork PR would test main's cli/action.yml instead of the checked out ref. Changing those tests so $/ works is saved for a follow-up.
  • Actions were already pinned to SHAs with version comments, every job already sets permissions:, and checkouts use persist-credentials: false except the two in release.yml that push.

Questions for review:

  • The release.yml checkouts keep persist-credentials: true since changesets/action and the release step push with git. Okay to leave as-is?

Testing

  • zizmor .github reports no findings, in both offline mode and with a GitHub token, now that ci: check Dependabot updates daily with a 7 day cooldown #713 is merged into this branch.
  • Every file under .github/workflows/ parses with js-yaml.
  • An earlier commit on this branch used $/ for every step: the CLI tests passed and the API tests failed on the missing dist/index.js.
  • --persona=pedantic findings (workflow-level permissions, concurrency, permission comments, and the fork notice in integration.yml) are unchanged.

Requirements

🤖 Generated with Claude Code

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@zimeg
zimeg requested a review from a team as a code owner November 20, 2026 08:09
@zimeg zimeg added this to the 4.1 milestone Nov 20, 2026
@zimeg zimeg added the github_actions Pull requests that update GitHub Actions code label Nov 20, 2026
@zimeg zimeg self-assigned this Nov 20, 2026
@changeset-bot

changeset-bot Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 8c15f11

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov

codecov Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.86%. Comparing base (cd7f31e) to head (8c15f11).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #714   +/-   ##
=======================================
  Coverage   99.86%   99.86%           
=======================================
  Files           8        8           
  Lines         732      732           
=======================================
  Hits          731      731           
  Misses          1        1           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@cchensh cchensh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On your $/cli question: I'd keep ./cli with the same inline # zizmor: ignore[self-repository] you used on ./, for now.

$/cli loads the action from the commit the workflow runs on, not from the checkout. The CLI jobs check out inputs.ref || github.event.pull_request.head.sha || github.sha (integration.yml:287). So:

  • A maintainer dispatch with ref: pull/N/head for a fork PR would test main's cli/action.yml against the fork's files.
  • On pull_request runs, $/ is the merge commit rather than the head SHA.
  • The API steps still use ./ from the checkout, so a single run would mix two versions of the repo.

The rest looks good: the ignore comments don't change any step, the needs: move in release.yml is cosmetic, and keeping push credentials on the release.yml checkouts is right.

@mwbrooks mwbrooks left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to @cchensh on $/cli: a maintainer-dispatched run for a fork PR would test main's cli/action.yml, so a fork change to it could pass without being tested. Keeping ./cli with the same ignore as ./ works for me. Happy to approve once that's in!

@WilliamBergamin WilliamBergamin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 Thanks @zimeg! Keeping ./ for the steps that run the built dist/ while still silencing zizmor is a tidy way to clear the audit without touching test behavior.
One blocking comment on $/cli, the same ask as the earlier reviews, the rest is optional 🙏

Comment thread .github/workflows/integration.yml Resolved
Comment thread .github/workflows/integration.yml Resolved
Comment thread .github/workflows/integration.yml Resolved
Comment thread .github/workflows/integration.yml Resolved
Comment thread .github/workflows/develop.yml Resolved
Comment thread .github/workflows/release.yml Resolved
Co-authored-by: William Bergamin <25348381+WilliamBergamin@users.noreply.github.com>
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@zimeg zimeg modified the milestones: 4.1, 4.1.1 Nov 20, 2026
@zimeg
zimeg requested review from cchensh and mwbrooks November 20, 2026 20:51

@cchensh cchensh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-checked at 8c15f11e: all four CLI steps are back on ./cli with the inline self-repository ignore, so they test the checked-out ref. No $/ is left, and every in-repo uses: across .github/workflows/ carries the ignore. The diff is now only ignore comments plus the publish key reorder, which the description notes. CLI tests (all three OSes), API, unit tests and CodeQL are green.

@zimeg zimeg changed the title ci: resolve zizmor findings across workflows ci: ignore zizmor self-repository warnings in testing workflows Nov 20, 2026
@zimeg

zimeg commented Nov 20, 2026

Copy link
Copy Markdown
Member Author

🌟 Thanks for the kind reviews @cchensh, @mwbrooks and @WilliamBergamin! Keeping ./ until these tests are reshaped for $/ 🛡️

@zimeg
zimeg merged commit 59def96 into main Nov 20, 2026
13 of 14 checks passed
@zimeg
zimeg deleted the zimeg-ci-zizmor-audit branch November 20, 2026 22:16

This branch was successfully deployed

1 active deployment
staging — 8c15f11e Deployed Nov 20, 2026 by zimeg via Run CLI tests (windows-latest) #405
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants