Skip to content

docs: add a maintainers guide section for updating the node version - #715

Merged
zimeg merged 4 commits into
mainfrom
zimeg-docs-maintainers-node-version
Nov 20, 2026
Merged

zimeg merged 4 commits into
mainfrom
zimeg-docs-maintainers-node-version

Conversation

@zimeg

@zimeg zimeg commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

Summary

This pull request adds an "Updating the Node version" section to the maintainers guide, right after "Releases".

  • 📅 Explains when this happens: GitHub deprecates a Node.js runtime on runners and runs.using accepts only supported nodeNN values. Changing it is a breaking change, so it ships as a major version, the way build!: update node runtime to version 24 #567 did.
  • 📝 Lists the places to update: action.yml, .nvmrc, package.json (engines, the dev image, @types/node), .github/dependabot.yml, and undici to match the major the runtime bundles.

Notes

Requirements

🤖 Generated with Claude Code

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@zimeg
zimeg requested a review from a team as a code owner November 20, 2026 08:54
@zimeg zimeg added this to the 4.1 milestone Nov 20, 2026
@zimeg zimeg added the docs Improvements or additions to documentation label Nov 20, 2026
@zimeg zimeg self-assigned this Nov 20, 2026
@changeset-bot

changeset-bot Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 7cc9423

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov

codecov Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.86%. Comparing base (cd7f31e) to head (7cc9423).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #715   +/-   ##
=======================================
  Coverage   99.86%   99.86%           
=======================================
  Files           8        8           
  Lines         732      732           
=======================================
  Hits          731      731           
  Misses          1        1           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@cchensh cchensh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Every file the guide names checks out (runs.using node24, .nvmrc, engines, the dev image, @types/node and the Dependabot ignores). Nits: #675 merged today, so the "still open" line in the description is out of date and a rebase would confirm the undici guidance. The undici bullet (maintainers_guide.md:117) could name package.json.

@WilliamBergamin WilliamBergamin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📚 Thanks @zimeg! A single checklist of every place the runtime lives will save the next major bump a lot of digging.
One blocking comment on the dependabot bullet now that #675 landed 🙏

Comment thread .github/maintainers_guide.md Resolved
Comment thread .github/maintainers_guide.md Resolved
zimeg and others added 2 commits November 20, 2026 06:41
Co-authored-by: William Bergamin <25348381+WilliamBergamin@users.noreply.github.com>
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@mwbrooks mwbrooks left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Appreciate this one @zimeg, having every place the runtime lives in one checklist will make the next major bump a lot less of a hunt.

@WilliamBergamin WilliamBergamin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📚 @zimeg thanks for the quick follow-up, the dependabot step now names both ignores, so the checklist matches every place that pins the runtime. 🚀

@zimeg zimeg modified the milestones: 4.1, 4.1.1 Nov 20, 2026
@zimeg

zimeg commented Nov 20, 2026

Copy link
Copy Markdown
Member Author

🌟 Thanks for the kind reviews @WilliamBergamin, @mwbrooks and @cchensh!

@zimeg
zimeg merged commit d715c74 into main Nov 20, 2026
14 checks passed
@zimeg
zimeg deleted the zimeg-docs-maintainers-node-version branch November 20, 2026 20:51

This branch was successfully deployed

1 active deployment
staging — 7cc9423b Deployed Nov 20, 2026 by zimeg via Run CLI tests (macos-latest) #403
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants