Repository navigation
docs: add a maintainers guide section for updating the node version - #715
Conversation
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #715 +/- ##
=======================================
Coverage 99.86% 99.86%
=======================================
Files 8 8
Lines 732 732
=======================================
Hits 731 731
Misses 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
cchensh
left a comment
There was a problem hiding this comment.
LGTM. Every file the guide names checks out (runs.using node24, .nvmrc, engines, the dev image, @types/node and the Dependabot ignores). Nits: #675 merged today, so the "still open" line in the description is out of date and a rebase would confirm the undici guidance. The undici bullet (maintainers_guide.md:117) could name package.json.
Co-authored-by: William Bergamin <25348381+WilliamBergamin@users.noreply.github.com> Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
WilliamBergamin
left a comment
There was a problem hiding this comment.
📚 @zimeg thanks for the quick follow-up, the dependabot step now names both ignores, so the checklist matches every place that pins the runtime. 🚀
|
🌟 Thanks for the kind reviews @WilliamBergamin, @mwbrooks and @cchensh! |
Summary
This pull request adds an "Updating the Node version" section to the maintainers guide, right after "Releases".
runs.usingaccepts only supportednodeNNvalues. Changing it is a breaking change, so it ships as a major version, the way build!: update node runtime to version 24 #567 did.action.yml,.nvmrc,package.json(engines, thedevimage,@types/node),.github/dependabot.yml, andundicito match the major the runtime bundles.Notes
undiciguidance matches fix: proxy input always fails due to an undici version mismatch #675, which pinnedundici@7and ignored its8.xmajor in.github/dependabot.yml.jsconfig.jsonchanged in build!: update node runtime to version 24 #567, but it now usesESNextandnodenext, which don't depend on the Node version, so it isn't listed.Requirements
🤖 Generated with Claude Code