Repository navigation
feat(account): warn that linking a workflow owner address is permanent - #614
Merged
anirudhwarrier merged 1 commit intoOct 8, 2026
Merged
Conversation
Show a permanence warning and confirmation prompt before link-key initiates linking, and forward --yes/--non-interactive from deploy's auto-link. DEVSVCS-5796 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
timothyF95
approved these changes
Oct 8, 2026
anirudhwarrier
deleted the
feature/DEVSVCS-5796-link-key-permanence-warning
branch
October 8, 2026 13:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves DEVSVCS-5796.
Once a workflow owner address is linked to an org, it can never be reused in another org. Users currently don't learn this until they hit an unclear error later on.
cre account link-keynow shows a permanence warning and asks for confirmation before it initiates linking. Already-linked addresses skip it.--yeson link-key is now actually read: it skips the prompt, but the warning still prints.cre workflow deployauto-link now passes--yesand--non-interactivethrough to link-key, so deploy shows the same warning for both EOA and MSIG owners.Breaking Changes
cre account link-key --non-interactiveandcre workflow deploy --non-interactiveagainst an unlinked owner now fail unless--yesis passed. This matches the existing unlink, delete and overwrite behaviour.Testing Verification
make lint: 0 issuesgo test $(go list ./... | grep -v usbwallet): all packages passTestConfirmPermanentLink: non-interactive without--yeserrors;--yesskips the promptTestTryAutoLinkUsesOnChainRegistry/confirmation_flags_are_forwarded_to_link-keymake gendoc: no doc changesmake test-e2e) and manual checks on staging with an unlinked address🤖 Generated with Claude Code