Skip to content

Achieve 100% test coverage - #6

Merged
samuel-williams-shopify merged 4 commits into
mainfrom
test/complete-coverage
Aug 13, 2026
Merged

Achieve 100% test coverage#6
samuel-williams-shopify merged 4 commits into
mainfrom
test/complete-coverage

Conversation

@samuel-williams-shopify

@samuel-williams-shopify samuel-williams-shopify commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add focused tests to achieve complete code coverage
  • reject unsupported compression encodings instead of emitting invalid compressed frames
  • report unsupported inbound compression as UNIMPLEMENTED
  • reject truncated gRPC prefixes and payloads while preserving clean end-of-stream handling
  • rely on the gRPC header policy for structured status and message extraction

Verification

  • COVERAGE=PartialSummary bundle exec bake test — 225 tests, 400 assertions, 492/492 lines (100.0%)
  • bundle exec bake covered:validate --paths .covered.db \;
  • bundle exec rubocop

Assisted-By: devx/48bd9802-2aca-41ba-856d-0b5bd523f9cf
@samuel-williams-shopify
samuel-williams-shopify force-pushed the test/complete-coverage branch 2 times, most recently from 70f010d to 122d843 Compare August 13, 2026 09:00
Assisted-By: devx/48bd9802-2aca-41ba-856d-0b5bd523f9cf
Assisted-By: devx/48bd9802-2aca-41ba-856d-0b5bd523f9cf
Assisted-By: devx/48bd9802-2aca-41ba-856d-0b5bd523f9cf
@samuel-williams-shopify
samuel-williams-shopify merged commit 1e70bc4 into main Aug 13, 2026
40 checks passed
@samuel-williams-shopify
samuel-williams-shopify deleted the test/complete-coverage branch August 13, 2026 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant