Optimize frame reading throughput#24
Merged
samuel-williams-shopify merged 4 commits intosocketry:mainfrom Apr 16, 2026
Merged
Conversation
Contributor
|
We independently verified the changes in this PR by re-applying each commit Environment
Scenarios
Large frames (70 kB, length=127 encoding) were also exercised but excluded from Results
Per-scenario breakdown (baseline vs final)
Notes
|
b75c0f7 to
fbb59fb
Compare
Co-authored-by: Claude <[email protected]>
fbb59fb to
5e52f03
Compare
0aa290a to
f9fb1e2
Compare
ae76bd5
into
socketry:main
18 of 21 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce per-frame overhead on the read path.
On a local benchmark (25K text frames, ~83B avg payload, Unix socket pair,
IO::Stream::Buffered) throughput improved ~26%.List of Changes
stream.read(2)instead of two separate readsstream.read(6)orstream.read(12))getbyte/unpack1instead ofunpack("C").firstunpack_framesfor single-frame messages (to avoidmap/join)Types of Changes
Contribution